[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: seeking review of golang-github-hashicorp-go-version v1.8.0



Upstream added a copyright notice:

https://salsa.debian.org/go-team/packages/golang-github-hashicorp-go-version/-/commit/a9da87e466345495e4bc89d5f38f5861aecc30cc#0398ccd0f49298b10a3d76a47800d2ebecd49859_1_1

You need to add it to debian/copyright.

Otherwise looks good to me, but a reverse rebuild is necessary here.
Did you try ratt?

We have used Salsa CI for this a couple of times for migrations, it has
a 100 job limit.  So please start a job like that.  Did you review
upstream code changes?   Looks like some potential for API difficulties,
but let's hope for the best...

/Simon

Federico Grau <donfede@casagrau.org> writes:

> Hello again debian-go team --
>
>
> I've updated package golang-github-hashicorp-go-version on salsa.d.o from
> v1.6.0 to v1.8.0 .
>
>     https://tracker.debian.org/pkg/golang-github-hashicorp-go-version
>
>
> This is a dependency of the `pat' package I've been collaborating on.  
>
>     https://lists.debian.org/debian-go/2025/12/msg00012.html
>
>     https://tracker.debian.org/pkg/pat
>
>
> The upstream changes were relatively minor.  
>
> I also made some minor debian updates (standards [no changes], copyright
> years, watch [format v3 to v5 using uscan generator]).  My review and testing
> appear ok.
>
> However, checking the reverse dependencies there appear to be ~342 other
> packages using golang-github-hashicorp-go-version.  I do not want to create
> issues.
>
>     https://salsa.debian.org/salsa-ci-team/pipeline/#build-reverse-dependencies
>
>
> As there are cycles I welcome review and constructive feedback if corrections
> are needed.  If all is well may the package be upload to unstable?
>
>
> Regards,
> donfede
>
> Fede Grau
>

Attachment: signature.asc
Description: PGP signature


Reply to: