"Martin Dosch" <martin@mdosch.de> writes: > Dear all, > > as this thread probably rotated out of view after one week, I'd like to > ask for a review again. Looks good to me, tag2upload'ed. Shouldn't you have upload rights for this package? Are you a DM? Is the GCM stuff really originally written for this package, as claimed by copyright/license headers, or is it copied from elsewhere? It looks a bit messy to not use standard AES-GCM, although I can see how the Go AES-GCM API interacts here. > Hopefully it's not considered rude to ask again after one week but this I suspect everyone will have different opinions, but for me patient friendly persistance nudges (like this one) has a chance to succeed as eventually one of the nduges may catch me in a moment of work (well, rather waiting for CI builds..) where attending to RFS requests is a plesant distraction. /Simon
Attachment:
signature.asc
Description: PGP signature