[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: golang-opentelemetry-contrib-dev: Upload to unstable



Maytham Alsudany <maytha8thedev@gmail.com> writes:

> Hi Simon,
>
> On Wed, 2024-01-24 at 10:03 +0100, Simon Josefsson wrote:
>> Hi.
>> 
>> I was looking at golang-opentelemetry-contrib-dev because it is needed
>> for etcd 3.5.x.  It seems to build fine, but upstream is doing several
>> concurrent releases, and we don't have the latest version in
>> experimental.  I wanted to upgrade it to the latest upstream version
>> before doing an upload.
>> 
>> Upstream etcd 3.4.x does not need golang-opentelemetry-contrib-dev.
>> 
>> Upstream etcd 3.5.11 (latest 3.5.x release) seems to use v0.46.0:
>
> etcd 3.5.11 uses v0.46.1 of the instrumentation/google.golang.org/grpc/otelgrpc
> module, which is versioned differently to the overall package. etcd actually needs
> golang-opentelemetry-contrib-dev >= 1.21.1.
>
> So I think it's best to update golang-opentelemetry-contrib to the latest version.

Yeah, alas, golang-opentelemetry-contrib needs newer
golang-opentelemetry-otel, otherwise you get build errors like this:

src/go.opentelemetry.io/contrib/config/trace.go:13:2: cannot find package "go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc" in any of:
	/usr/lib/go-1.21/src/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc (from $GOROOT)
	/build/golang-opentelemetry-contrib-0.47.0/obj-x86_64-linux-gnu/src/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc (from $GOPATH)
src/go.opentelemetry.io/contrib/config/trace.go:14:2: cannot find package "go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp" in any of:
	/usr/lib/go-1.21/src/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp (from $GOROOT)
	/build/golang-opentelemetry-contrib-0.47.0/obj-x86_64-linux-gnu/src/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp (from $GOPATH)
src/go.opentelemetry.io/contrib/config/trace.go:19:2: cannot find package "go.opentelemetry.io/otel/trace/noop" in any of:
	/usr/lib/go-1.21/src/go.opentelemetry.io/otel/trace/noop (from $GOROOT)
	/build/golang-opentelemetry-contrib-0.47.0/obj-x86_64-linux-gnu/src/go.opentelemetry.io/otel/trace/noop (from $GOPATH)
src/go.opentelemetry.io/contrib/propagators/opencensus/binary.go:22:2: cannot find package "go.opentelemetry.io/otel/bridge/opencensus" in any of:
	/usr/lib/go-1.21/src/go.opentelemetry.io/otel/bridge/opencensus (from $GOROOT)
	/build/golang-opentelemetry-contrib-0.47.0/obj-x86_64-linux-gnu/src/go.opentelemetry.io/otel/bridge/opencensus (from $GOPATH)

To have confidence in an update of otel, I first built reverse
dependencies of otel in sid but there are failures:

https://salsa.debian.org/jas/golang-opentelemetry-otel/-/pipelines/629791

I think this really indicate FTBFS bugs in cadvisor, crowdsec, and
gitlab-ci-multi-runner?  Rebuilding packages in sid should work.

I will try to update otel to 1.23.0-rc.1 and see if I get it to build.
Build failures on the three previous packages can be probably be
attributed to FTBFS bugs in those three packages, rathern than
incompatibility with otel 1.23.0-rc1.  But you don't know for certain...

/Simon

Attachment: signature.asc
Description: PGP signature


Reply to: