Re: RFS: easygen version 4.1.0
On Sun, Dec 29, 2019 at 5:45 AM Utkarsh Gupta
<guptautkarsh2102@gmail.com> wrote:
>
> Hi Tong,
>
> On 29/12/19 12:40 am, Tong Sun wrote:
> > I've updated the upstream and salsa repo at:
> >
> > https://salsa.debian.org/go-team/packages/easygen
> >
> > The package was tested on both gbp and sbuild. It's also lintian-clean.
> >
> > Could you please reviewing/sponsoring this?
>
>
> d/copyright mentions Files-Excluded which is not really used.
> Could you please remove it? Or tell me why is it there?
>
> While you're at it, could you also change MIT to Expat as well?
> It's better to use the latter than the former, but this is just a
> suggestion :)
Fixed in:
https://salsa.debian.org/go-team/packages/easygen/commit/3c026b163ff2491cee0f711d7210bb92165cd6ea
I.e., I think that's what you meant (I took a look all the default
licenses provided by GitHub by default and I found MIT but not Expat,
so I presume you meant to change the d/copyright license statement
itself, not the actual license file)
> While building and checking, I got the following warning:
> W: easygen source: repackaged-source-not-advertised
To fix it, I was trying to find the warning itself first, but I wasn't able to.
Here is my build log, of `gbp buildpackage` (and sbuild):
http://paste.debian.net/1123082/
I found 5 lines containing KW "repack", but they are all about a souce
`easygen` depends on.
Mover over, I got my easygen souce via `gbp import-orig --uscan`.
All in all, I don't where this warning is coming from, and have no
idea what went wrong and how to fix it. Could you elaborate a bit
please?
> Let me know once you've fixed this, I'd be happy to sponsor :)
Thanks a lot Utkarsh!
Reply to: