[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#208238: marked as done (locales: wrong charset for et_EE)



On Fri, Apr 23, 2004 at 10:26:59AM +0200, Petter Reinholdtsen wrote:
> 
> [Denis Barbier]
> > The attached dpatch was used to close this bug.  But its comment is not
> > accurate, this dpatch adds a et_EE.ISO-8859-15 locale (and is then
> > identical to upstream fix) whereas bug log and dpatch comment seem
> > to imply that et_EE charset was changed from ISO-8859-1 to ISO-8859-15.
> > 
> > Denis
> > [2 locale-et_EE.dpatch <text/plain; us-ascii (7bit)>]
> > #! /bin/sh -e
> > 
> > # All lines beginning with `# DP:' are a description of the patch.
> > # DP: Description: List et_EE with charset ISO-8859-15 as a supported locale
> 
> I do not quite understand how you interpret "List et_EE with charset
> ISO-8859-15 as a supported locale" to mean that the charset was
> changed.

Because of the comment written in your dpatch:
    * locales/et_EE: Change default charset for et_EE locale from
      ISO-8859-1 to ISO-8859-15, to reflect the content of
      <URL:http://www.eki.ee/itstandard/contents.html>.

But one has to know this file syntax to see that this change occurs
within comments and has thus no impact; unfortunately the one
who committed this patch was not careful enough and wrote in the changelog
  debian/patches/locale-et_EE.dpatch: Fix et_EE locale incorrect charset
which might in turn confuse users.

Denis



Reply to: