Re: opencpn_2.5.0+dfsg-1_i386.changes REJECTED

[Hamish <hamish_b@yahoo.com>]

Mike O'Connor <ftpmaster@debian.org> wrote:

> Hi maintainer,
> 
> I must reject this package.
> 
> opencpn-2.5.0\Findgps.cmake contains a license not mentioned
> in the copyright file

this looks like a simple oversight, simple to fix. (Anton? :)


> opencpn-2.5.0\include\tiny{str,xml}.h have a license not
> mentioned in the copyright file

they are rm -rf'd in debian/rules (in favour of the system's
copy),  but anything appearing in the .orig.tar.gz file must be
documented. again, a simple fix to avoid the current omission.

> opencpn-2.5.0\include\triangulate.h is in the public domain

another easy fix, just needs to be listed.

> opencpn-2.5.0\plugins\CMakeLists.txt and
> opencpn-2.5.0\plugins\dashboard_pi\CMakeLists.txt
> (and others)
>         mention the wxwidgets
> license,  Which files does this cover?

I dunno. Dave?

> I stopped checking here for other copyright file
> shortcomings, there might be more.

anyone have hints on the best way for us to audit before resubmit?

> You package Build-Depends on a purely virtual package:
> libglu-dev, you must provide a non-virtual package and
> present the virtual package as an alternative.

now fixed in debiangis svn.

do we make the next submission attempt as version-2, or keep as
ver-1?


Hamish