Holger Levsen wrote:
Hi Nicolas, now really looking at your package :)
/grin
On Sunday 22 June 2008 23:16, Nicolas Spalinger wrote:You kindly reviewed/sponsored the previous version of the package (the design reviews), could you please do the same for the updated package: http://mentors.debian.net/debian/pool/main/t/ttf-sil-andika/ttf-sil-andika_ 1.0.basic-1.dscReading the README.Debian I understand that "basic" is really part of the fonts name, not the version... but maybe thats the way SIL works, "DesRev" in the README was also part of the name while in the Debian package it was part of the version..
This is the way it has been handled for this particular design review process. It's understood as a some kind of release tag within the wider project.
In debian/copyright you write that the debian packaging is copyright 2008 by you. The old file said 2007, so it should be "2007-2008" :)
Yes, good point. Thanks for spotting that.
There are no linebreaks in README.TXT anymore :) (Upstream change, I suggest to leave it like it is, I just have the habbit to comment on everything I see :)
Yes, it's a minor thing. I agree that we can probably leave it like that.
So, really no blocker to not upload :) I expect you want the version like it is...(?) should I fix the year in debian/copyright for you while/before building the package before uploading?
Yes, please, I'll reflect the date fix in svn.
regards, Holger
Thanks again, -- Nicolas Spalinger http://scripts.sil.org http://pkg-fonts.alioth.debian.org/ https://launchpad.net/people/fonts
Attachment:
signature.asc
Description: OpenPGP digital signature