David Bremner <david@tethera.net> writes: > Xiyue Deng <manphiz@gmail.com> writes: > >> >> I think we understand the issue well and the fix has been tested with >> the previous version of emacsen-common (which also means to reproduce >> one needs to use snapshot.d.o), so I wouldn't worry to much about the >> risk of the fix and would like to see this as part of Trixie to prevent >> any unforeseen failure. >> >> Let me know if you all agree and I'll prepare a new debian/trixie branch >> with the fixes only. > > I'm not concerned so much with the risk of the fix as with the necessity > of it. I suggest filing a pre-approval bug with the release team to > avoid extra work/uploads if they are not convinced. > > d Actually when trying to use snapshot.d.o to reproduce the issue, I realized that this issue is actually connected to Bug#1106291: when upgrading an addon, the addon's helper/remove script should run during unpacking to do the clean up, which is supposed to wipe the directory under "elpa/", and Bug#1106291 prevented that. Now emacsen-common/3.0.8 fixed that erroneous behavior, with all addons' helper/remove scripts properly run, this issue should have been prevented as well. Therefore this bug can be considered effectively fixed with Bug#1106291 as well. I think it is also desirable that dh-elpa need not concern itself with any cleaning up and should leave that to the helper/remove script. So now I think it's actually fine to close this bug. I'll leave the decision to you and Sean. -- Regards, Xiyue Deng
Attachment:
signature.asc
Description: PGP signature