[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1091462: marked as done (dh-make-elpa: Use "upstreamvcs" as suggested upstream remote name)

Your message dated Fri, 27 Dec 2024 15:38:54 -0800
with message-id <87zfkgy9v5.fsf@debian-hx90.lan>
and subject line Re: Bug#1091462: dh-make-elpa: Use "upstreamvcs" as suggested upstream remote name
has caused the Debian Bug report #1091462,
regarding dh-make-elpa: Use "upstreamvcs" as suggested upstream remote name
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1091462: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1091462
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: dh-make-elpa
Version: 0.19.5
Severity: wishlist

Currently dh-make-elpa suggests using "upstream" as upstream remote name
in its manpage.  This works, but could be confusing as DEP-14 also
suggests using "upstream/latest" as the branch name for upstream repo.
I would like to suggest using "upstreamvcs" as upstream remote name
instead, which is also used by dh-make.

-- System Information:
Debian Release: 12.8
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-28-amd64 (SMP w/16 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages dh-make-elpa depends on:
ii  dh-elpa                 2.0.16
ii  libarray-utils-perl     0.5-3
ii  libdebian-source-perl   0.122
ii  libfile-find-rule-perl  0.34-3
ii  libfile-grep-perl       0.02-3
ii  libgit-repository-perl  1.325-3
ii  libtrycatch-perl        1.003002-3+b1
ii  perl                    5.36.0-7+deb12u1

Versions of packages dh-make-elpa recommends:
ii  devscripts  2.23.4+deb12u2

dh-make-elpa suggests no packages.

-- no debconf information

-- 
Regards,
Xiyue Deng

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Sean Whitton <spwhitton@spwhitton.name> writes:

> Hello,
>
> On Fri 27 Dec 2024 at 01:20am -08, Xiyue Deng wrote:
>
>> Sean Whitton <spwhitton@spwhitton.name> writes:
>>
>>> Hello,
>>>
>>> On Thu 26 Dec 2024 at 03:23pm -08, Xiyue Deng wrote:
>>>
>>>> Package: dh-make-elpa
>>>> Version: 0.19.5
>>>> Severity: wishlist
>>>>
>>>> Currently dh-make-elpa suggests using "upstream" as upstream remote name
>>>> in its manpage.  This works, but could be confusing as DEP-14 also
>>>> suggests using "upstream/latest" as the branch name for upstream repo.
>>>> I would like to suggest using "upstreamvcs" as upstream remote name
>>>> instead, which is also used by dh-make.
>>>
>>> I'd prefer to leave it as it is.  The 'vcs' in 'upstreamvcs' is
>>> redundant, because of course it's a VCS -- it's a git remote.
>>>
>>
>> Right.  It's just that this name clash with "upstream" or
>> "upstream/latest" is kind of inconvenient, especially in magit (I should
>> have mentioned this in the report) that when you try to switch to a
>> branch and as you try to auto-complete for "upstream", it shows all
>> remote branches starting with upstream as well, which can be confusing.
>>
>> Using a different name helps a little, and I guess this could be why
>> dh-make started suggesting "upstreamvcs".  It doesn't have to be that
>> name, of course.  Anything different from "upstream" helps :)
>
> Thanks for explaining.  I think with git you just have to deal with this
> across the board.  For example dgit-repos uses a remote branches
> namespace called 'dgit' and the branches are 'dgit/sid', 'dgit/bookworm'
> etc., so you frequently have to deal with 'dgit/dgit/sid'.
>
> So, I'm not sure trying to help in this way is a job for dh_make_elpa.
>
> If someone regularly runs into this problem, they can just use a
> different one themselves, the manpage name is just a recommendation,
> after all.
>

I thought that was the case too, until when I used "git clone -o
upstreamvcs ..." I got an error when dh-make-elpa trying to find the
remote branch at [1].

But I think what you said makes sense.  I guess it's also easy enough
that after the initialization you just rename the branch.

> (I'm a bit biased here because I don't think we should be maintaining
> upstream branches at all, for most packages, as you know from reading
> some of my dgit tutorial manpages.)
>

Ack.  I sensed that the dgit-maint-* workflows didn't make any upstream
branch for a reason.  Now it makes more sense :)

Anyway, this is just a suggestion/wishlist, so closing as the workaround
is easy enough.

> -- 
> Sean Whitton

[1] https://salsa.debian.org/emacsen-team/dh-make-elpa/-/blob/master/lib/DhMakeELPA/Command/Packaging.pm?ref_type=heads#L453

-- 
Regards,
Xiyue Deng

Attachment: signature.asc
Description: PGP signature


--- End Message ---
Reply to: