Re: New package: elpa-modus-themes
- To: Dhavan V <quark@codingquark.com>
- Cc: Debian Emacsen team <debian-emacsen@lists.debian.org>
- Subject: Re: New package: elpa-modus-themes
- From: Lev Lamberov <dogsleg@debian.org>
- Date: Tue, 13 Oct 2020 11:34:05 +0500
- Message-id: <[🔎] 877druvdlu.fsf@localhost>
- In-reply-to: <2E1EC4F6-4D84-4DCD-8D96-3A1EA9DB3450@codingquark.com>
- References: <6QOstF5eLYqy4-8bAHe_Zrfa3Y3wLXwWlJ0FHOOS2A-VXI5vaC7LSd3RWIK3GhLcIf4pqx6-EFYqZHuQoIZXfcKabGU9ALg1gD-2yrIaI-A=@dwayo.com> <87lfkp546m.fsf@localhost> <mSAZNk0-65Uv34K-G59AyseLh1_PfvQ27syKPHx0QLOo5mYqFefXe1LLlUjEYEdlPek5m7Va9isQt3WG9dYG6qrL4h9xb-ddS7oUSmpkQ68=@codingquark.com> <87imfs649z.fsf@localhost> <amvJyHVe1VXF_-UH0YaJAswZhTZYvouC7ZxBlj-_Ym7W4ZjIdZFaTrmXvXFCOxTpP5by570XfEIzxOwFt4S0TDwYciGpxDJlMjbR-gLof9g=@codingquark.com> <87ftaw5p04.fsf@localhost> <DkpOjUZK1Oq1NfGM7vBbXitsofe--1RfaU4pm8y-2pWKqzyDU6l4FLY2XzJKXWvuVnrh1puC93d9q2ejJofxBNmNUNxqRT8HgrlpomQe0Fw=@codingquark.com> <ahBAQSwhqdLIWNKD516x7X6VNvMJO3irgL9V-KP391dS8cgmTqWmAnQHnOsfL-_B93dcB3fFUzrFXMkN2U322f4urKly76RdWIj0LhpHN4k=@codingquark.com> <87pn893bfn.fsf@localhost> <2E1EC4F6-4D84-4DCD-8D96-3A1EA9DB3450@codingquark.com>
Hi Dhavan,
Пн 12 окт 2020 @ 07:22 Dhavan V <quark@codingquark.com>:
> Updated to upstream v0.13.0, kindly take a look :)
looked into your changes, and here are some comments.
Accidentally your "internal" LAN email was used instead of your
"external" one:
E: modus-themes changes: bogus-mail-host Changed-By codingquark@rpi3.lan
E: elpa-modus-themes: bogus-mail-host-in-debian-changelog codingquark@rpi3.lan
Upstream now ships additional documentation in Info format, which
is reflected in the changelog. It's better to ship it in the Debian
package and install it properly.
Also, I think that it's better not to push tags to Salsa when the
release is not ready. Now you need to rewrite debian/0.13.0-1 tag, which
Salsa may not allow you to do due to your permissions. In case Salsa
will not allow you to rewrite the tag, ping me and I'll remove it for
you.
Cheers!
Lev
Reply to: