[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#965048: marked as done (elpa-magithub: Dependency on deprecated ‘magit-popup’ causes warning, should migrate to ‘transient’)

Your message dated Thu, 06 Aug 2020 17:39:28 +0000
with message-id <[🔎] E1k3jrU-000Cyx-QF@fasolo.debian.org>
and subject line Bug#968006: Removed package(s) from unstable
has caused the Debian Bug report #965048,
regarding elpa-magithub: Dependency on deprecated ‘magit-popup’ causes warning, should migrate to ‘transient’
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
965048: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=965048
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: elpa-magithub
Version: 0.1.7-2
Severity: important
Tags: upstream

When using current Magit (release “2.99.0.git0957.ge8c7bd03-1” from
Debian) while Magithub is installed, Magit repeatedly interrupts with
a warning:

    Warning (magit): Magit no longer uses Magit-Popup.
    It now uses Transient.
    See https://emacsair.me/2019/02/14/transient-0.1.

    However your configuration and/or some third-party package that
    you use still depends on the `magit-popup' package. But because
    `magit' no longer depends on that, `package' has removed it from
    your system.

    If some package that you use still depends on `magit-popup' but
    does not declare it as a dependency, then please contact its
    maintainer about that and install `magit-popup' explicitly.

    […]

(the full text is from function ‘magit--magit-popup-warning’ in
‘/usr/share/emacs/site-lisp/elpa-src/magit-2.99.0/magit-obsolete.el’.)

The interruption is often enough that the Magit user interface becomes
effectively unusable, hence this bug is “Severity: important”.

This warning occurs on my system is because Magithub has a dependency
on ‘magit-popup’, but does not declare it in a way that the Emacs
package manager can detect. A debugging backtrace shows:

=====
Debugger entered--entering a function:
* magit--magit-popup-warning()
  magit-define-popup-action(magit-dispatch-popup 72 "Magithub" magithub-dispatch-popup 33)
  (progn (magit-define-popup-action (quote magit-dispatch-popup) 72 "Magithub" (function magithub-dispatch-popup) 33) (define-key magit-status-mode-map "H" (function magithub-dispatch-popup)))
  (lambda nil (progn (magit-define-popup-action (quote magit-dispatch-popup) 72 "Magithub" (function magithub-dispatch-popup) 33) (define-key magit-status-mode-map "H" (function magithub-dispatch-popup))))()
  eval-after-load-helper("/usr/share/emacs/site-lisp/elpa/magit-2.99.0/magit.elc")
  run-hook-with-args(eval-after-load-helper "/usr/share/emacs/site-lisp/elpa/magit-2.99.0/magit.elc")
  do-after-load-evaluation("/usr/share/emacs/site-lisp/elpa/magit-2.99.0/magit.elc")
  require(magit)
  byte-code("\300\301!\210\302\303\304\305\306\307%\210\310\311\312\313\314DD\315\306\303\316\317\320\321&\011\207" [require magit custom-declare-group magit-extras nil "Additional functionality for Magit." :group magit-extensions custom-declare-variable magit-gitk-executable funcall function #f(compiled-function () #<bytecode 0x194d141>) "The Gitk executable." :set-after (magit-git-executable) :type string] 10)
  autoload-do-load((autoload "magit-extras" "Like `next-line' but with Magit-specific shift-selection.\n\nMagit's selection mechanism is based on the region but selects\nan area that is larger than the region.  This causes `next-line'\nwhen invoked while holding the shift key to move down one line\nand thereby select two lines.  When invoked inside a hunk body\nthis command does not move point on the first invocation and\nthereby it only selects a single line.  Which inconsistency you\nprefer is a matter of preference.\n\n(fn &optional ARG TRY-VSCROLL)" t nil) magit-next-line)
  command-execute(magit-next-line)
=====

According to the warning message:

=====
* If you use `magit-popup' to define your own popups but do not
  modify any of Magit's old popups, then you have to install
  `magit-popup' explicitly.  (You can also migrate to Transient,
  but there is no need to rush that.)
=====

So according to that, either of those resolutions would be sufficient
to avoid this breakage.


-- System Information:
Debian Release: bullseye/sid
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.7.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_AU.UTF-8), LANGUAGE=en_AU.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_AU.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages elpa-magithub depends on:
ii  elpa-ghub+          0.3-5
ii  elpa-git-commit     2.99.0.git0957.ge8c7bd03-1
ii  elpa-magit          2.99.0.git0957.ge8c7bd03-1
ii  elpa-markdown-mode  2.4-1
ii  elpa-s              1.12.0-3
ii  emacsen-common      3.0.4

Versions of packages elpa-magithub recommends:
ii  emacs              1:26.3+1-2
ii  emacs-gtk [emacs]  1:26.3+1-2

elpa-magithub suggests no packages.

-- no debconf information

-- 
 \        “If you go to a costume party at your boss's house, wouldn't |
  `\     you think a good costume would be to dress up like the boss's |
_o__)                          wife? Trust me, it's not.” —Jack Handey |
Ben Finney <bignose@debian.org>

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Version: 0.1.7-2+rm

Dear submitter,

as the package magithub has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see https://bugs.debian.org/968006

The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.

Please note that the changes have been done on the master archive and
will not propagate to any mirrors until the next dinstall run at the
earliest.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
ftpmaster@ftp-master.debian.org.

Debian distribution maintenance software
pp.
Sean Whitton (the ftpmaster behind the curtain)

--- End Message ---
Reply to: