Re: New package: elpa-modus-themes

[Lev Lamberov <dogsleg@debian.org>]

Hi Dhavan,

Вс 14 июн 2020 @ 16:51 Dhavan Vaidya <dhavan@dwayo.com>:

> I have created salsa repository[1] and have pushed `master` with
> `debian/` setup. Please review my work as this is my first time packaging
> from scratch!
>
> Thanks!
>
> PS: bremner has helped on oftc, thanks!
>
> [1]: https://salsa.debian.org/emacsen-team/elpa-modus-themes

I briefly looked into your package and here are some comments:

 - d/control: in your case short description should not start with a
   capital letter (s/Set/set/)

 - d/control: Vcs-* fields point to modus-themes (which doesn't exist,
   as I can see), but the repo you linked is elpa-modus-themes

 - d/copyright: copyright holder in this case is Free Software
   Foundation, which is clearly stated in *.el (with years 2019-2020),
   not Protesilaos Stavrou

 - d/copyright: could you add author's email, which is
   <info@protesilaos.com>? You may add this to Upstream-Contact field

 - I think that it's better to install CHANGELOG.org via
   dh_installchangelogs (that is, via the correspoding override in
   d/rules), not via d/docs

 - d/elpa contains d/modus-themes-pkg.el, but where is it in your repo?

I don't see any other issues, but still I'd recommend someone else look
into it (probably, after fixing the issues above). Otherwise, it looks
good. Thanks for you contribution!

Cheers!
Lev