Re: Help/sponsorship needed in upstreaming multiple elpa/melpa packages to debian
On 22.05.2020 19:30, Sean Whitton wrote:
Hello Sławomir,
Hopefully the following reviews are useful; let me know when addressed.
Please note I haven't tried to build anything yet.
Sorry I haven't noticed notification about this email and I did read it
only a few days ago, also had less time recently. Thanks for the review,
it's very helpful I don't know why I've missed so many things.
On Wed 20 May 2020 at 09:09PM +02, Sławomir Wójcik wrote:
dockerfile-mode:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=929291
https://salsa.debian.org/Valdaer/dockerfile-mode
https://mentors.debian.net/package/dockerfile-mode
- copyright years do not match those claimed by upstream
- does not close ITP
- Upstream-Name field is blank?
- old std-ver
fixed
>
>> groovy-emacs-modes:
>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=961048
>> https://salsa.debian.org/Valdaer/groovy-emacs-modes
>> https://mentors.debian.net/package/groovy-emacs-modes
>
> - needs binary packages for each .el file so that we have one binary
> package corresponding to each package on MELPA
Good catch I don't know why I missed this, double checked that and only
grails-mode is a separate package on melpa, all other files are packaged
in groovy-mode
> - copyright years do not match those claimed by upstream
haven't found the year in license file, what is the process/policy in
that case? do we look in file headers/comments first? I have done so
now, before I've taken the year from repository first commit.
> - does not close ITP
> - no Source: field in d/copyright (Policy actually requires this)
> - old debhelper compat & std-ver
> - you'll want to patch in Package-Depends or list dependencies manually
> in d/control (headers of files suggest there are various elpa-*
> dependencies)
>
fixed
I've pushed changes to the repos and reuploaded newly built packages to
debian mentors.
Cheers,
Sławomir
Reply to: