[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#921413: marked as done (TODO list for RFS: php-elisp/1.21.0-1 [ITA])

Your message dated Sun, 15 Sep 2019 19:49:50 +0000
with message-id <E1i9aWs-0001bJ-V3@fasolo.debian.org>
and subject line Bug#921413: fixed in php-elisp 1.21.4+50.g977bca2-1
has caused the Debian Bug report #921413,
regarding TODO list for RFS: php-elisp/1.21.0-1 [ITA]
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
921413: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=921413
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: php-elisp
Version: 1.21.0-1
Severity: normal

Hi Antoine,

Thank you for much for sponsoring src:php-elisp!  I've created a
tracking bug for these issues, replied inline, and plan to fix them in
the next upload.

On Sat, Feb 02, 2019 at 12:40:40PM -0500, Antoine Beaupré wrote:
> I uploaded the package, but I'll note some improvements that could be
> done on it:
> 
>  1. newer versions of debhelper allow deduplicating information between
>     the control file and debian/compat. just remove the latter and
>     change the control dependency to "debhelper-compat (=11)" (or
>     12). see also:
> 
>     https://nthykier.wordpress.com/2019/01/04/debhelper-compat-12-is-now-released/

Oh!  Thank you for telling me about this :-)  (I didn't know)

>  2. very minor, but i like to keep the "transitional package" phrase on
>     a separate line in package descriptions so it's more obvious to
>     someone looking at the description

Do you mean like this?:
Short description:  transitional package from old-foo to new-foo package
 Old-foo description, and why new-foo...
 .
 This is a transitional dummy package and can be safely removed.

>  3. why was the php-root self-test disabled? what's the next step for
>     that patch? can it be sent upstream or will we have to carry this on
>     forever?

(ert-deftest php-project-root ()
  (should (string= (abbreviate-file-name default-directory)
                   (php-project-get-root-dir))))

Evals to "/<<PKGBUILDDIR>>/" instead of the real path.  It will take
some time to review the changelogs and git history of my other
packages to find the workaround for this sbuild/buildd quirk, because
I didn't write "PKGBUILDDIR" as a keyword the last time I ran into it.
Oops...  Thus, I confess to choosing the fastest/easiest path since
the freeze is so close.

> Thanks for your work! :)

You're welcome :-D

--
Nicholas

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: php-elisp
Source-Version: 1.21.4+50.g977bca2-1

We believe that the bug you reported is fixed in the latest version of
php-elisp, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 921413@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Nicholas D Steeves <nsteeves@gmail.com> (supplier of updated php-elisp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 15 Sep 2019 15:20:24 -0400
Source: php-elisp
Architecture: source
Version: 1.21.4+50.g977bca2-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Emacsen team <debian-emacsen@lists.debian.org>
Changed-By: Nicholas D Steeves <nsteeves@gmail.com>
Closes: 903092 921413
Changes:
 php-elisp (1.21.4+50.g977bca2-1) unstable; urgency=medium
 .
   * New upstream release, plus 50 upstream commits (all self-tests now pass).
   * Switch to debhelper-compat 12 and drop debian/compat.
   * Switch to machine-readable copyright format 1.0 (Closes: #903092).
   * Drop bin:php-elisp dummy transitional package.
     - Break and replace all php-elisp versions older than this one.
     - Elpa-php-mode now provides php-elisp.
   * Add Maintainer noted in php-mode.el as Upstream-Contact.
   * Update Suggests from upstream documentation.
   * Drop emacs25 from enhances because emacs was unversioned for buster.
   * Add elpa-imenu-list to Suggests.
   * Note in description that PHP Mode supports both Flycheck and Flymake.
   * Cleanup trailing whitespace in d/control.
   * Drop 0001-Disable-php-project-root-selftest.patch and use
     upstream-provided fixes included in their +50 commits (Closes: #921413).
   * elpa-test: create file needed for upstream self-test; doing it here
     rather than in rules solves the autopkgtest failure case.
   * Override_dh_elpa_test to clean up file needed for upstream self-test.
   * Drop Ola Lundqvist from Uploaders as requested on
     debian-emacsen@lists.debian.org.
Checksums-Sha1:
 ca7635f53b78b49912e2b06c15d9e5cd84e02694 2084 php-elisp_1.21.4+50.g977bca2-1.dsc
 71b111d0354a8a77c205bb0e3ce9532aa498bbca 72168 php-elisp_1.21.4+50.g977bca2.orig.tar.xz
 852be0c94373d415b7e48f09133708c49dbee737 5636 php-elisp_1.21.4+50.g977bca2-1.debian.tar.xz
 df21bf1272dd3ed94f809916962055658dd7f0e0 7831 php-elisp_1.21.4+50.g977bca2-1_amd64.buildinfo
Checksums-Sha256:
 723c0f4cc8860d1b80aba46bb7b49e46964dbc0c86a6a3e540b2ef80d278776f 2084 php-elisp_1.21.4+50.g977bca2-1.dsc
 aba939c4e71cbdc81895ef084a7ba06e2b31c2a08cb03bcf14c67ce9c1ea212c 72168 php-elisp_1.21.4+50.g977bca2.orig.tar.xz
 83bf4ce642de20f0d994a6ad24e450f1ab90f0aad0d828eabeeb8428a7817226 5636 php-elisp_1.21.4+50.g977bca2-1.debian.tar.xz
 63e3cac49658e776800a38bdfa31b8e94dd5346a9f0403686cf5ce2275ec0322 7831 php-elisp_1.21.4+50.g977bca2-1_amd64.buildinfo
Files:
 5990d397b4280b6d4bab782fdba651b3 2084 lisp optional php-elisp_1.21.4+50.g977bca2-1.dsc
 0e6e24fc583e3e72892810e532671a9a 72168 lisp optional php-elisp_1.21.4+50.g977bca2.orig.tar.xz
 c96ed2b4ff6ce37c451922090af41dfa 5636 lisp optional php-elisp_1.21.4+50.g977bca2-1.debian.tar.xz
 306b3b0a870f0a91b2924d066a8cca31 7831 lisp optional php-elisp_1.21.4+50.g977bca2-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJHBAEBCgAxFiEE4qYmHjkArtfNxmcIWogwR199EGEFAl1+j9ITHG5zdGVldmVz
QGdtYWlsLmNvbQAKCRBaiDBHX30QYSt9D/sFmSLEWB0A9KoWvhvUclHvcavIcJBn
J2CZTki23g0RcWXzzH99anCxmp1UPSfcJ+XFFdQnf0UjGPlrbb5F3WuvMmVTPTdm
BNe/GXUQPhgrH3Wz6ZhlMaln1D3Fi65GTKRYnqSTS4CS+UTzJw+fWgnmvxlkZwII
HcLgkByWk6btvGBsQbhdzZmjj3F4NtOJ8TGJTbktxCdmaHy6ABJUZGUix8out7LF
vIebtxTsaI0HJx/MZuU8I5Ud226W4Gor4zDXxfsJSrGo8+nSUsKMPTrvn0BatBDy
hndp/U09NaNy/R7B4M5uWXB0bDFbxaNU85HjbpkatJDx1UM2ruwSImtcWEu9ASgh
NHBAAMMiQaY7jpNJqed8jRhdzOUX89XmQq1Cw6CDJ/QI1Mdg3/+qUVFy9GipZRdl
9VgAuuxy7qtEqFgoLocgSblNAy8Yj9vq24a1AxERKWGfMRV5aHkRnWAGeUhcW4CV
OoXax3V5iR1Tjp8ve5H5/UYDACbfhyi09B+xKnKi2Z3HnqxOWlZGgo8mXbqvIhwa
HRbTkPK9UpK1KzEkFCqkAraZb0U+sJOpzT4x2LVx+tmlge+PjTprLpW+5cG4zRwy
yQcFIIpb2e/ou6PvkHjWkQ7fmR9QB0/nuD7Yc+3F9kF6TKTildUWXbvSLzYta78M
cncN+jnzKSo2oA==
=yYqC
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: