Hi Holger, On Mi 22 Okt 2014 11:58:17 CEST, Holger Levsen wrote:
Hi Mike, On Mittwoch, 22. Oktober 2014, Mike Gabriel wrote:Please revert this change. Or at least use Depends: debian-edu-artwork (>= ${source:Version}), debian-edu-artwork (<< ${source:Version}.1) There are places in the debian debian-edu-artwork source package that causes a strict versioned dependency between the common debian-edu-artwork bin:package and the theme bin:packages debian-edu-artwork-<theme>.I've seen that, discussed it (even highlighted you in that discussion), thought about it and didnt find any valid reason to have these in place. Please explain why they are needed.
Sorry, I missed that on IRC...
(Oh, and the reason I noticed was that I noticed that the relationship was = and not >=, which is broken, as it breaks binNMUs. (Which given the way the package builds, might actually be needed...))
You are correct about the binNMU argument. Please use "debian-edu-artwork (>= ${source:Version}),
debian-edu-artwork (<< ${source:Version}.1)".
So my changed *fixed* something.Please ask before committing such changes.Please explain when asking for doing changes ;-P [18:18] < h01ger> | schweer: sunweaver: or could you see any reasons why there should be versioned depends? [18:44] < schweer> | h01ger: unsure, the versioned depends are due to sunweaver. [18:45] < h01ger> | i'd understand versioned depends on an specific version [18:45] < h01ger> | but on the latest, always? thats already the default [18:45] < schweer> I guess that's unneeded. [18:45] < h01ger> | so its just really needed, if it absolutly must be met, for example for libraries, compilers, data, whatever [18:46] < h01ger> | but d-e-a-$foo > 0.50 will work nicely with d-e-a a version less [18:46] < h01ger> | as i see things [18:47] < schweer> yes. [19:12] < h01ger> | so that cleanup was good So again: why? cheers, Holger
1) the dpkg diversion of files are handled by bin:package debian-edu-artwork (so it is essential that all diversions are in place before d-e-a-<theme> gets installed).
e.g. debian-edu-artwork-<theme> from 0.49-1 would fail installation if debian-edu-artwork was still on level 0.48.
2) in the update-debian-edu-artwork-* scripts we test for several files in debian-edu-artwork (or diverted by debian-edu-artwork) to exist. If debian-edu-artwork hasn't done its work during (pre-)installation, the postinst of those other bin:package (-<theme>) might fail.
Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
Attachment:
pgpps5bzkvlXG.pgp
Description: Digitale PGP-Signatur