[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: r73151 - in trunk/src/debian-edu-config: cf debian



Hi Mike,

On Freitag, 8. April 2011, mike-gabriel-guest@alioth.debian.org wrote:
> New Revision: 73151
> 
> Added:
>    trunk/src/debian-edu-config/cf/cf.adduser
> Modified:
>    trunk/src/debian-edu-config/cf/cf.homes
>    trunk/src/debian-edu-config/cf/cfengine.conf
>    trunk/src/debian-edu-config/debian/changelog

In this commit you've several times used a cfengine construct like this:

> +            BeginGroupIfNoMatch 'FIRST_GID=500'
> +                LocateLineMatching 'FIRST_GID=1000'
> +                ReplaceLineWith 'FIRST_GID=500'
> +            EndGroup

Which can be much easier written as:

Replace 'FIRST_GID=500' With 'FIRST_GID=1000'

Please improve your changes.


Thanks & cheers,
	Holger


Reply to: