[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Preliminary review of dpkg-genbuildinfo



Guillem Jover:
> On Mon, 2015-04-27 at 15:09:36 +0200, Guillem Jover wrote:
> > In any case, given this, your initial change does make sense, but I
> > think it's in the wrong place. I've instead modified Dpkg::Dist::Files
> > to always sort the files list, so that any other program parsing that
> > file will automatically get reproducible results.
> > 
> > Initially I wanted to preserve the insertion order to preserve
> > compatibility with the previous implementation, but always sorting these
> > seems right to me so I went ahead with that now.
> 
> This was included in 1.18.0, but your forward ported patch now makes
> it fail the test suite, you might want to drop that one. :)

Indeed. Thanks for the tip! :)

-- 
Lunar                                .''`. 
lunar@debian.org                    : :Ⓐ  :  # apt-get install anarchism
                                    `. `'` 
                                      `-   

Attachment: signature.asc
Description: Digital signature


Reply to: