Re: Review of pu/multiarch/master
On Fri, 2011-11-25 at 17:21:32 +0100, Raphael Hertzog wrote:
> I took some time to review your work in progress (pu/multiarch/master
> while it was pointing to 5602d63c7669a9cb5ba293faff8cf85b3accc746).
>
> I have pushed some small fixes for you in pu/multiarch/for-guillem,
> there are "fixup!" commits ready to be "autosquashed" by you. Most
> of the changes ary typo/doc updates but there's a bit more, see below.
Thanks, I've done a quick scan, merged some, and fixed others in some
other way. I've been since the 23rd on a trip, but will be back
tomorrow, when I'll handle the rest of the issues you found, the
remaning interface changes, and will send a status mail.
> *** commit a8c90816abb1f8b4c077e92a04faed5311c7483f
> “libdpkg: Change pkg_db_find_pkg() to create new arch instances”
>
> It's tagged "Sponsored-by: Linaro" but you're marked as author,
> I think it's a mistake due to the fact that you split a commit of mine.
Indeed, there was another one like that, either due to commit splitting
or due to author being switched on conflict resolution. I've fixed
those, but there might be still other similar issues, in any case I
always check for this kinds of issues when merging into master.
regards,
guillem
Reply to: