Re: [PATCH/RFC] dpkg-shlibdeps: ignore shell scripts
On Wed, 21 Apr 2010, Jonathan Nieder wrote:
> It can be convenient in debian/rules to simply run
>
> dpkg-shlibdeps debian/tmp/usr/bin/*
Why? I mean dh_shlibdeps already does the right thing and is passing
binaries only to dpkg-shlibdeps.
> The heuristic used to detect scripts here is very simple: any file
> starting with the two bytes #! is assumed to be a script. Maybe in
> the future the rule will change to be more sophisticated. It is a
> public function so other packages can make use of it.
That would be the wrong thing to check. We want to verify if it's a
ELF object and if not then we skip it. And we should not skip it silently
IMO as it was explicitly passed in a list of stuff to analyze.
We already have the required Dpkg::Shlibs::Objdump::is_elf().
Cheers,
--
Raphaël Hertzog
Like what I do? Sponsor me: http://ouaza.com/wp/2010/01/05/5-years-of-freexian/
My Debian goals: http://ouaza.com/wp/2010/01/09/debian-related-goals-for-2010/
Reply to: