Re: Bug#476100: devscripts: debuild should not fork dpkg-buildpackage
Hi,
On Tue, 15 Apr 2008, Adam D. Barratt wrote:
> I've just committed a set of patches to debuild:
>
> + Run dpkg-buildpackage directly where possible, rather than emulating it.
> Emulation will still be used if any of the clean, dpkg-source, build,
> binary, dpkg-genchanges or final-clean hooks are defined, as dpkg
> does not currently support them.
>
> This should be fairly self-explanatory :-) I've verified that the pdksh
> FTBFS is now reproducible using debuild.
That's great! I think a vast majority of users do not use those hooks and
will thus use dpkg-buildpackage.
> + Automatically preserve the (C, CPP, CXX, LD and F)FLAGS variables and
> the corresponding *FLAGS_EXTEND variables
> + Add *FLAGS and *FLAGS_EXTEND support to the emulated dpkg-buildpackage
s/EXTEND/APPEND/ IIRC.
> + When running dpkg-buildpackage directly, pass through unrecognised
> options (with a warning) rather than aborting the build ourselves
>
> The theory behind this change is that if dpkg-buildpackage acquires new
> command line switches that debuild isn't aware of, then they can still
> be used. If the option doesn't exist then the reporting of that issue
> simply moves from debuild to dpkg-buildpackage.
Looks reasonable.
> At this point I'd like to suggest that we do one or more of the
> following:
> a) close this bug in the 2.10.26 upload
> b) downgrade it
> c) block it against #476221
>
> (I suspect some combination of b and c would be the least controversial :)
Do whatever you prefer, I don't mind. I think dpkg-buildpackage will not
change any more in the lenny timeframe and the new features will wait
until lenny+1 anyway.
Cheers,
--
Raphaël Hertzog
Le best-seller français mis à jour pour Debian Etch :
http://www.ouaza.com/livre/admin-debian/
Reply to: