[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#959191: marked as done (release-notes: mention configuration file split in logrotate)

Your message dated Sat, 2 May 2020 20:29:18 +0200
with message-id <[🔎] 41ac25fb-765a-40c8-afcd-734fef2eaf65@debian.org>
and subject line Re: Bug#959191: release-notes: mention configuration file split in logrotate
has caused the Debian Bug report #959191,
regarding release-notes: mention configuration file split in logrotate
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
959191: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=959191
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release-notes

With version 3.14.0 [1] logrotate split the configuration for btmp and
wtmp into separate configuration files.
There are bug reports regarding this issue: #945932, #928516, #922045.

Over at #946779 Julien suggested adding a section (5.3.10 ?).

Maybe the section can be like the following:

   The shipped configurations for "/var/log/btmp" and "/var/log/wtmp" have
   been split from the main configuration file (/etc/logrotate.conf) into
   separate standalone files (/etc/logrotate.d/btmp respectively
   /etc/logrotate.d/wtmp).

   If you had modified /etc/logrotate.conf in this regard, make sure
   to re-adjust the two new files to your needs and drop any references to
   (b|w)tmp from the main file, to avoid logrotate skip rotation due to a
   duplicate definition.


Best regards,
   Christian Göttsche

[1]: https://github.com/logrotate/logrotate/blob/master/ChangeLog.md#3140---2018-03-09

--- End Message ---
--- Begin Message --- 
Hi,

On 01-05-2020 09:06, Andrei POPESCU wrote:
>> It would also need a title; maybe something like
>>
>>    5.3.10  Split in configuration for logrotate
>>  
>>> Maybe the section can be like the following:
>>>
>>>    The shipped configurations for "/var/log/btmp" and "/var/log/wtmp" have
>>>    been split from the main configuration file (/etc/logrotate.conf) into
>>>    separate standalone files (/etc/logrotate.d/btmp respectively
>>                                                       ^^^^^^^^^^^
>>>    /etc/logrotate.d/wtmp).
>>
>> "Respectively" isn't a conjunction, and there's no need here for
>> anything more complicated than "and".
>>
>>>
>>>    If you had modified /etc/logrotate.conf in this regard, make sure
>>             ^^^
>> s/had/have/
>>
>>>    to re-adjust the two new files to your needs and drop any references to
>>>    (b|w)tmp from the main file, to avoid logrotate skip rotation due to a
>>                                                      ^^^^
>>>    duplicate definition.
>>
>> Quick fix: s/skip/skipping/.  Probably better:
>>
>>                                   since duplicate definitions can cause errors.
> 
> FWIW, LGTM.

Pushed, thanks. Should be available after the next build.

Paul

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
Reply to: