[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#959191: release-notes: mention configuration file split in logrotate



Hi,

On 01-05-2020 09:06, Andrei POPESCU wrote:
>> It would also need a title; maybe something like
>>
>>    5.3.10  Split in configuration for logrotate
>>  
>>> Maybe the section can be like the following:
>>>
>>>    The shipped configurations for "/var/log/btmp" and "/var/log/wtmp" have
>>>    been split from the main configuration file (/etc/logrotate.conf) into
>>>    separate standalone files (/etc/logrotate.d/btmp respectively
>>                                                       ^^^^^^^^^^^
>>>    /etc/logrotate.d/wtmp).
>>
>> "Respectively" isn't a conjunction, and there's no need here for
>> anything more complicated than "and".
>>
>>>
>>>    If you had modified /etc/logrotate.conf in this regard, make sure
>>             ^^^
>> s/had/have/
>>
>>>    to re-adjust the two new files to your needs and drop any references to
>>>    (b|w)tmp from the main file, to avoid logrotate skip rotation due to a
>>                                                      ^^^^
>>>    duplicate definition.
>>
>> Quick fix: s/skip/skipping/.  Probably better:
>>
>>                                   since duplicate definitions can cause errors.
> 
> FWIW, LGTM.

Pushed, thanks. Should be available after the next build.

Paul

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: