[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#959191: release-notes: mention configuration file split in logrotate



On Jo, 30 apr 20, 20:06:51, Justin B Rye wrote:
> Christian Göttsche wrote:
> > Package: release-notes
> > 
> > With version 3.14.0 [1] logrotate split the configuration for btmp and
> > wtmp into separate configuration files.
> > There are bug reports regarding this issue: #945932, #928516, #922045.
> 
> To me this seems more like something that should go in the logrotate
> NEWS.Debian file, but maybe that's too hard to get into Stable, so
> I'll just proofread the suggested addition:

Indeed.
 
> > Over at #946779 Julien suggested adding a section (5.3.10 ?).
> 
> It would also need a title; maybe something like
> 
>    5.3.10  Split in configuration for logrotate
>  
> > Maybe the section can be like the following:
> > 
> >    The shipped configurations for "/var/log/btmp" and "/var/log/wtmp" have
> >    been split from the main configuration file (/etc/logrotate.conf) into
> >    separate standalone files (/etc/logrotate.d/btmp respectively
>                                                       ^^^^^^^^^^^
> >    /etc/logrotate.d/wtmp).
> 
> "Respectively" isn't a conjunction, and there's no need here for
> anything more complicated than "and".
> 
> > 
> >    If you had modified /etc/logrotate.conf in this regard, make sure
>             ^^^
> s/had/have/
> 
> >    to re-adjust the two new files to your needs and drop any references to
> >    (b|w)tmp from the main file, to avoid logrotate skip rotation due to a
>                                                      ^^^^
> >    duplicate definition.
> 
> Quick fix: s/skip/skipping/.  Probably better:
> 
>                                   since duplicate definitions can cause errors.

FWIW, LGTM.

Kind regards,
Andrei
-- 
http://wiki.debian.org/FAQsFromDebianUser

Attachment: signature.asc
Description: PGP signature


Reply to: