Jonas Smedegaard <jonas@jones.dk> writes: ... > Yes, which means you can fast-track for *THAT* reason - unrelated to > code smell, which is specifically what I was talking about. I understand that you were reacting to the idea that one can just stomp on the existing packaging simply because it "smells bad", but I don't think that was really what was being suggested. I took Andreas's question to be more about: If a package is obviously suffering badly from neglect, and urgently needs an upload anyway, is it reasonable to fix as many problems as you can while you are at it, or should one only do the bare minimum to get past the RC bug that's prompting the upload? Having looked at how it was done, I applaud Andreas for doing a proper job. If the package gets any attention from the maintainer in future, I would guess that the fact that the package is now in a much better state will be rather motivating. If the maintainer happens to disagree with any of the changes, each is in a separate commit, so would be very easily reverted, but every change seemed like a worthwhile improvement to me. Cheers, Phil. -- |)| Philip Hands [+44 (0)20 8530 9560] HANDS.COM Ltd. |-| http://www.hands.com/ http://ftp.uk.debian.org/ |(| Hugo-Klemm-Strasse 34, 21075 Hamburg, GERMANY
Attachment:
signature.asc
Description: PGP signature