[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#804947: RFS: inform/6.31.1+dfsg-2



Control: owner -1 !

Hi,

On Fri, 13 Nov 2015 20:44:40 +0000, James Cowgill <james410@cowgill.org.uk>
wrote:
> On Fri, 2015-11-13 at 16:36 +1100, Ben Finney wrote:
> > Package: sponsorship-requests
> > Severity: wishlist
> > Control: tags 698980 + pending
> > Control: block 698980 by -1
> > 
> > I am looking for a sponsor for my package ‘inform’:  
> 
> Since I've used inform before, I had a small look at the package.
> However, I'm not a DD so I can't upload it for you.

Thanks for the review, James!

Ben, I am a DD so I can upload it for you (once you fix the issues,
including those James points out).

[...]
> The package FTBFS when build with dpkg-buildpackage -B:

and with dpkg-buildpackage -A (which would be nice to have since the source
package produces an arch-independent binary package alongside the
arch-dependent one).

> debian/rules:
>  Why not use dh?
>  Why not use dh_autoreconf?

+1 from me for both these recommendations, especially since you've done a
fair bit of the work already by splitting up the installation files.

README.Debian-source should be README.source (policy 4.14,
https://www.debian.org/doc/debian-policy/ch-source.html#s-readmesource).

debian/rules isn't really the place to comment on policy, I'd suggest filing
a bug against policy... You could also just use uscan and drop the various
get-orig-source targets entirely.

Thanks for taking the time to work on this!

Regards,

Stephen

Attachment: pgpxG48DIsW29.pgp
Description: OpenPGP digital signature


Reply to: