Re: Review cyphesis-cpp
d/copyright fixed, pushed to git and will now upload
lets see if we make it :)
Your homework below (for during the freeze :))
--
tobi
I. Am Samstag, den 25.10.2014, 15:19 +0200 schrieb Tobias Frost:
> Hi Olek,
>
> note: I'll try to stay on IRC, #debian-games -- for shorter feedback
> loops as time is short (only a few hours left!)
>
> Let me know when you looked over my remarks.
>
> Here are the remarks:
>
> Am Samstag, den 25.10.2014, 05:50 -0500 schrieb Olek:
> > Ok, first round of fixes complete and uploaded. :)
> >
> > On 10/24/2014 02:32 PM, Tobias Frost wrote:
> >
> > > d/control: The versions of the B-Ds can be dropped -- even oldstable
> > > contains the minimum version.
> > > libavahi-client-dev (>= 0.6.4),
> > > libboost-dev (>=1.40),
> > > libbullet-dev (>= 2.77),
> > > libgcrypt11-dev (>= 1.2),
> > >
> > > (I stopped here, please check the rest; check also the binary packages'
> > > dependencies.)
> >
> > Done and done. I removed any that were older than oldstable.
> >
> > >
> > > d/cyphesis-cpp-clients.install -> there is a blank line on top.
> > > d/*.install -> manpages should be installed by dh_installman
> >
> > Ah, yes, good point! Fixed.
> >
> > >
> > > postinst:
> > > The username "cyphesis" could collide with a real-world username. Read
> > > https://wiki.debian.org/AccountHandlingInMaintainerScripts for a
> > > suggestion. The user does not need a shell, I guess, so
> > > use /usr/sbin/nologin as shell.
> > >
> > > As you are askink for a password using debconf, please read
> > > http://www.fifi.org/doc/debconf-doc/tutorial.html about passwords.
> >
> > Thanks for the good references. Fixed according to the suggestions I
> > found there, along with a little additional Googling.
> >
> > >
> > > d/docs:
> > > Don't install NEWS, THANKS and AUTHORS -- they have no information for
> > > the user.
> >
> > Ok.
> >
> > >
> > > Ok, first round completed. I especially did not yet d/copyright review,
> > > but I will do it after I've got feedback from you regarding above.
> >
> > I got some previous feedback on the d/copyright so it's been completely
> > rewritten with the assistance of upstream. It *should* be an easy review. ;)
> >
> > -Olek
>
> d/control:
> Is the
> Conflicts: cyphesis-cpp-acorn, cyphesis-cpp-werewolf
> nedded? See the Policy 7.4 and maybe 7.6
> I think it would be safe just to remove the Conflicts -- I could not
> find any reference to those two packages.
>
> d/copyright: (using license-reconsile and some greps to remove the
> noise)
>
> rulesets/mason/define_world_aglanor.py has:
> #Copyright (C) 2005 WorldForge (See the file COPYING for details).
>
> and probably here's a typo:
> 2005, Miguel Guzmán <aglanor@gmail.com>
> is it Miguel Guzman?
>
> rulesets/mason/world/objects/buildings/StoneHouse.py
> is
> (C) 1999 Kosh (See the file COPYING for details).
>
> rulesets/mason/world/objects/outdoor/Gravestone.py: Trying to match
> "Erik Hjortsberg (See the COPYING for details)" against "Erik Ogenvik
> <erik@ogenvik.org>" but it does not look like a good match.
>
> Some typos:
>
>
> I: cyphesis-cpp-clients: spelling-error-in-binary usr/games/cyaddrules
> Overriden Overridden
> I: cyphesis-cpp-clients: spelling-error-in-binary usr/games/cyclient
> Unkown Unknown
> I: cyphesis-cpp-clients: spelling-error-in-binary usr/games/cyclient
> exceded exceeded
> I: cyphesis-cpp-clients: spelling-error-in-binary usr/games/cycmd
> Overriden Overridden
> I: cyphesis-cpp-clients: spelling-error-in-manpage
> usr/share/man/man6/cyclient.6.gz overriden overridden
> I: cyphesis-cpp-clients: spelling-error-in-manpage
> usr/share/man/man6/cyclient.6.gz overriden overridden
> I: cyphesis-cpp-clients: spelling-error-in-manpage
> usr/share/man/man6/cycmd.6.gz overriden overridden
> I: cyphesis-cpp-clients: spelling-error-in-manpage
> usr/share/man/man6/cycmd.6.gz overriden overridden
> I: cyphesis-cpp-clients: spelling-error-in-manpage
> usr/share/man/man6/cycmd.6.gz supress suppress
> I: cyphesis-cpp-clients: hyphen-used-as-minus-sign
> usr/share/man/man6/cyphesis-tools.6.gz:17
> N: ----
> N: Processing binary package cyphesis-cpp (version 0.6.0-1, arch
> amd64) ...
> I: cyphesis-cpp: spelling-error-in-binary usr/games/cyphesis Unkown
> Unknown
> I: cyphesis-cpp: spelling-error-in-binary usr/games/cyphesis exceded
> exceeded
> I: cyphesis-cpp: spelling-error-in-manpage
> usr/share/man/man6/cyphesis.6.gz overriden overridden
> I: user script /var/cache/pbuilder/build//5262/tmp/hooks/B90lintian
> finished
>
> Would be great if you could fix the typos...
>
>
>
Reply to: