29.09.2013 00:22, Juhani Numminen пишет: > Hi Anton, > > In addition to Boris’ notes here are my suggestions. > > How is the orig tarball (i.e. gmqcc_0.2-678-g100eaf9.orig.tar.gz) > created? What are the commands? If you have a local pristine-tar branch, please push it. > >> http://anonscm.debian.org/gitweb/?p=pkg-games/gmqcc.git;a=blob;f=debian/docs;hb=HEAD > No need to have LICENSE there. Please read Lintian warnings, this is > catched by it: > W: gmqcc: extra-license-file usr/share/doc/gmqcc/LICENSE > >> http://anonscm.debian.org/gitweb/?p=pkg-games/gmqcc.git;a=blob;f=debian/control;hb=HEAD > Again, lintian has something to say: > I: gmqcc source: vcs-field-not-canonical http://git.debian.org/?p=pkg-games/gmqcc.git > http://anonscm.debian.org/gitweb/?p=pkg-games/gmqcc.git > I: gmqcc source: vcs-field-not-canonical git://git.debian.org/pkg-games/gmqcc.git > git://anonscm.debian.org/pkg-games/gmqcc.git > > > Thanks for your work, > -- > Juhani Numminen > > Hi Boris and Juhani. Thank you about your notes. > 1) Please re-read document [1]. It recommends to use Expat license name instead of MIT. > >2) Why do you use more strict license (GPL-2+) for debian package? > It would be good idea to use the same license (Expat) as program > uses. And debian/copyright file will become shorter. =) Because it was suggested by dh_make by default +) Done. But I'm not sure that I made it right (I made empty description in second define Expat license). > Please remove all comments. They are useless. I left "#export DH_VERBOSE=1" for now. Is it OK? > 2) Is override_dh_auto_install really necessary? Have you tried to > build the package without it? Anyway, I have to override PREFIX, because Makefile has it as /usr/local what is not allowed in Debian. > How is the orig tarball (i.e. gmqcc_0.2-678-g100eaf9.orig.tar.gz) > created? What are the commands? If you have a local pristine-tar > branch, please push it. In this case I download the commit [1] from github.com as a zip file and recompressed it into orig.tar.gz. Sometimes I do that by git hard reset on custom commit and tar zcf <pkg-version>.orig.tar.gz --exclude-vcs. What is the best way if there is no archive from author? About next lintian warnings: I installed Lintian v2.5.19~bpo70+1 and anyway don't see those warnings :( [2] > W: gmqcc: extra-license-file usr/share/doc/gmqcc/LICENSE Done. I thought this file has some additional info about license for users and should be in docs. Removed. > gmqcc source: vcs-field-not-canonical Done. Also changed the homepage to github pages. Thanks for hints. Let's go on review. New version: [3] [1] https://github.com/graphitemaster/gmqcc/tree/100eaf913700836457bf17e8f487744dedb84e44 [2] cat ~/.lintianrc info=yes display-info=yes display-experimental=yes pedantic=yes show-overrides=yes color=auto verbose=yes [3] http://anonscm.debian.org/gitweb/?p=pkg-games/gmqcc.git;a=commit;h=0b8b3700c5003e52dcb5300aff34156aa8945611
Attachment:
signature.asc
Description: OpenPGP digital signature