[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#611364: desktop-base: Please document the reason for the "sync" usage in postinst

On ven., 2011-01-28 at 14:34 +0100, Niels Thykier wrote:
> I hear that desktop-base uses "sync" in the postinst and that it has a valid
> reason for doing so.  That being said, the postinst does not have any inline
> documentation/comments clarifying it.

Yeah, a comment might be a good idea. For the record (and to add another
source of information) the changelog says:

   - run sync before updating grub to be sure the grub background has been     
      written to disk.

Or else the grub background is not found when it runs update-grub.

> It might also be prudent document the consequences of (or even emit a
> warning if) eatmydata (or similar) is used. 

People using eatmydata should be aware that it can eat their data. They
might have valid reason to use it, but they should be prepared for the
side effects. Afaict there's no way to call fsync easily from a shell
script so...


Attachment: signature.asc
Description: This is a digitally signed message part

Reply to: