[Git][ftp-team/dak][master] dep11-basic-validate.py: use `with` statement to manage file

Subject: [Git][ftp-team/dak][master] dep11-basic-validate.py: use `with` statement to manage file

Date: Wed, 27 Jan 2021 18:07:06 +0000

Title: GitLab

65428330

by Ansgar at 2021-01-27T19:05:14+01:00

dep11-basic-validate.py: use `with` statement to manage file

Also read the file as text instead of reading it as binary and
decoding ourselves.

@@ -161,16 +161,15 @@ def validate_data(data):
  def validate_file(fname):
 -    f = None
      if fname.endswith('.gz'):
 -        f = gzip.open(fname, 'r')
 +        opener = gzip.open
      elif fname.endswith('.xz'):
 -        f = lzma.open(fname, 'r')
 +        opener = lzma.open
      else:
 -        f = open(fname, 'r')
 +        opener = open
 -    data = str(f.read(), 'utf-8')
 -    f.close()
 +    with opener(fname, 'rt', encoding='utf-8') as fh:
 +        data = fh.read()
      return validate_data(data)

Reply to: