[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [dak/master] Fix indentation



On 05/21/2013 18:51, Luca Falavigna wrote:
> --- a/config/debian/dinstall.functions
> +++ b/config/debian/dinstall.functions
> @@ -627,9 +627,9 @@ function changelogs() {
>          mkdir -p /srv/backports-master.debian.org/rsync/export/changelogs
>          cd /srv/backports-master.debian.org/rsync/export/changelogs
>          rsync -aHW --delete --delete-after --ignore-errors /srv/backports-master.debian.org/export/changelogs/. .
> +        remove_changelog_lock
>          trap remove_changelog_lock EXIT TERM HUP INT QUIT
>      fi
> -    remove_changelog_lock
>  }

That looks strange: changelogs() now calls remove_changelog_lock right
before it adds a trap to call the same function.

Shouldn't the trap be moved to the top right after changelogs() acquired
the lock?

Ansgar


Reply to: