Bug#975381: Subject: libinih: drop Debian's custom vendorisation
- To: Stephan Lachnit <stephanlachnit@protonmail.com>, 975381@bugs.debian.org
- Subject: Bug#975381: Subject: libinih: drop Debian's custom vendorisation
- From: Andreas Metzler <ametzler@bebt.de>
- Date: Thu, 24 Dec 2020 16:32:50 +0100
- Message-id: <X+S0oukc/n7D6BSI@argenau.bebt.de>
- Reply-to: Andreas Metzler <ametzler@bebt.de>, 975381@bugs.debian.org
- In-reply-to: <Q9yEsKnh_OG-P43URIGFld7iBcKBRNhc6N5aKyCzC6sF7TGshHr2jfIuc2cR8FqWD1vmqI_FnjukFh-waxLZRDQwm-taRxzMpFMOX8jGB6o=__34633.7114622415$1605961284$gmane$org@protonmail.com>
- References: <Q9yEsKnh_OG-P43URIGFld7iBcKBRNhc6N5aKyCzC6sF7TGshHr2jfIuc2cR8FqWD1vmqI_FnjukFh-waxLZRDQwm-taRxzMpFMOX8jGB6o=__34633.7114622415$1605961284$gmane$org@protonmail.com> <Q9yEsKnh_OG-P43URIGFld7iBcKBRNhc6N5aKyCzC6sF7TGshHr2jfIuc2cR8FqWD1vmqI_FnjukFh-waxLZRDQwm-taRxzMpFMOX8jGB6o=@protonmail.com>
On 2020-11-21 Stephan Lachnit <stephanlachnit@protonmail.com> wrote:
[...]
> Because the library was designed for embedded use cases where every
> little bit of performance matters, the runtime patch was refused
> upstream. Dropping the runtime patch from Debian actually isn't
> problem, no reverse dependency of libinih uses compile time options
> anyway.
Hello,
goxel does.[1]
goxel-0.10.6/src/utils/ini.h:#define INI_HANDLER_LINENO 1
and gnutls would, too.
So imho inih upstream needs a interface that allows linking either
dynamically against system libinih or statically against the included
copy without changing the source with something equivalent to the
compile time options. The current Debian-patched version requires source
changes depending on what linkage is targeted, upstream's version of the
dynamic library just does not work when these compile time options are
needed.
cu Andreas
[1] Which is probably why it actually uses the static copy although it
depends on libinih. (#978021)
--
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'
Reply to: