Your message dated Sat, 08 Dec 2018 18:20:38 +0000 with message-id <E1gVhDS-0006fP-0w@fasolo.debian.org> and subject line Bug#912041: fixed in grub-cloud 0.0.4 has caused the Debian Bug report #912041, regarding grub-cloud-amd64: don't work around being tested by piuparts to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org immediately.) -- 912041: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=912041 Debian Bug Tracking System Contact owner@bugs.debian.org with problems
--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: grub-cloud-amd64: don't work around being tested by piuparts
- From: Holger Levsen <holger@debian.org>
- Date: Sat, 27 Oct 2018 17:18:29 +0200
- Message-id: <20181027151829.b4kwzhbvqcbcflci@layer-acht.org>
Package: grub-cloud-amd64 Version: 0.0.2 Severity: important Dear Maintainer, in your postinst you are trying to detect whether it's being run in a piuparts test, to workaround #912038 ("grub-cloud-amd64: fails to install"), which is detected by piuparts but can also be triggered by anyone installing it manually, with this code: if [ ${PIUPARTS_TEST:-} ]; then echo "Running Piuparts detected, exiting." >&2 exit 0 fi This is bad, don't do that. piuparts tests stuff for a reason and as #912038 shows, your package is still buggy. In discussion on #-release before uploading grub-cloud 0.0.2 you claimed that grub-cloud is only useful to install in cloud environments (which are chroots) and thus detecting a chroot would not work. Still all packages (aimed for a stable Debian release) must be installable in chroots, also yours. So instead of detecting whether the package is being tested by piuparts you should detect whether grub-cloud-amd64 is being installed in a cloud-chroot and only then do whatever it takes to active grub. For that you can create some file while preparing the cloud chroot (say /etc/.cloud_env) and only if that file is present you do those things you now dont do if the variable $PIUPARTS_TEST is defined. I've also filed a bug against lintian to detect maintainer scripts using this variable as no maintainer script needs to do this. This is similar to the lintian test detecting autokpkgtests just running "exit 0" or "true". The bug against lintian is #912040. -- cheers, Holger ------------------------------------------------------------------------------- holger@(debian|reproducible-builds|layer-acht).org PGP fingerprint: B8BF 5413 7B09 D35C F026 FE9D 091A B856 069A AA1CAttachment: signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
- To: 912041-close@bugs.debian.org
- Subject: Bug#912041: fixed in grub-cloud 0.0.4
- From: Bastian Blank <waldi@debian.org>
- Date: Sat, 08 Dec 2018 18:20:38 +0000
- Message-id: <E1gVhDS-0006fP-0w@fasolo.debian.org>
Source: grub-cloud Source-Version: 0.0.4 We believe that the bug you reported is fixed in the latest version of grub-cloud, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 912041@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Bastian Blank <waldi@debian.org> (supplier of updated grub-cloud package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmaster@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Sat, 08 Dec 2018 19:06:50 +0100 Source: grub-cloud Binary: grub-cloud-amd64 Architecture: source Version: 0.0.4 Distribution: unstable Urgency: medium Maintainer: Debian Cloud Team <debian-cloud@lists.debian.org> Changed-By: Bastian Blank <waldi@debian.org> Description: grub-cloud-amd64 - GRand Unified Bootloader (cloud setup) Closes: 912038 912041 Changes: grub-cloud (0.0.4) unstable; urgency=medium . * Do nothing if no flag file exists. (closes: #912038, #912041) Checksums-Sha1: e626858eee2db0a9a89f30b98d5680c309d7b06c 1281 grub-cloud_0.0.4.dsc 32bde9f7becfd06dff9a6cdf1089fe44ed849251 13332 grub-cloud_0.0.4.tar.xz 97acad9c39d6790979190f6bd4098d11cdfa3c2e 5149 grub-cloud_0.0.4_source.buildinfo Checksums-Sha256: 8f5164c01be364690d0474179c3d5e1102ed31afa53c2390505f549bf5b9acd1 1281 grub-cloud_0.0.4.dsc 8a8523ecdc318b256ff1abd93f81144970a705447f81c2557ee39a15e372c820 13332 grub-cloud_0.0.4.tar.xz 26f4aed6772c881f6d767d97796ca4d0d1a3ac3346c5a655576604a4a91b6521 5149 grub-cloud_0.0.4_source.buildinfo Files: 3589afc7101abb5764670f7488fccfdb 1281 admin optional grub-cloud_0.0.4.dsc b54e4830def81a8c971fbbe9dec4df0f 13332 admin optional grub-cloud_0.0.4.tar.xz 297f0ca1a6826489d1d82f9184b44ae0 5149 admin optional grub-cloud_0.0.4_source.buildinfo -----BEGIN PGP SIGNATURE----- iQFFBAEBCgAvFiEER3HMN63jdS1rqjxLbZOIhYpp/lEFAlwMCGYRHHdhbGRpQGRl Ymlhbi5vcmcACgkQbZOIhYpp/lEvowgAqTO5SkQucSz10MVuT5gq7tss05rrPAD5 7rjkJxJKSI0wOPkUBSeYqFXhEAHpgLKjRg3jfPrhCVawSxHOk3lAZ5lJ4tqZfB5D ms+CFlE5heLhkyaI30iTNQky6g0LHEfNBa1U47+uHjiS9a0Qcw/u+YasoqA3/DxA CBucUk6WAAgYR3gCulo9LcXoACZez0yGQ3Pq5g5T1S0BpYTFEJr+19MmfgIAfR7D w5Z9JhwFW8K/f8cgX6HxTYqKmErqNoHLqCrFf3sGPf2/w9paqES53aFzf/ixZNRL B58an4mC8mLd1zm5fUIHOyu863QWQxGkeA0y0PqluHOo5E2sHah9ZQ== =4ES2 -----END PGP SIGNATURE-----
--- End Message ---