Re: Bug#783826: cloud-utils growroot doesn't work with newer sfdisk >= 2.26 : fixed patch solution for newer and older sfdisk

[Thomas Goirand <thomas@goirand.fr>]

On 05/04/2015 10:39 PM, Scott Moser wrote:
> On Mon, 4 May 2015, Antonio Terceiro wrote:
>
> > On Mon, May 04, 2015 at 12:48:37PM -0400, Scott Moser wrote:
> > > > Also, what about the do-not-use-EXIT-when-trapping.patch patch which I had to
> > > > add in Debian? Could you please apply them both?
> > >
> > > EXIT is posix compatible. you really should change the shell to be posix
> > > compatible rather than changing all programs to expect a subset of poxix
> > > shell.
> > >    http://pubs.opengroup.org/onlinepubs/000095399/utilities/trap.html
> >
> > EXIT is supported by dash ... I have just tested the script below and it
> > works as expected on all Debian release since at least wheezy.
>
> I think its not supported in the static busybox that is in debian
> initramfs.
>
> Not sure, but I think that was the problem.

Scott, you are correct, the issue is in early boot using busybox within 
the initramfs.

I'm ok with having the issue fixed in Stretch for adding support for 
EXIT in busybox, but as you know, it will be a lot more difficult to fix 
the issue in Jessie and Wheezy, so I think it's better to just keep the 
patch to not use EXIT.

What's the problem for applying the patch upstream? Don't you think that 
other distribution may as well have the issue? Shouldn't we just try to 
stay on the safe side here?

Cheers,

Thomas Goirand (zigo)