[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1032900: marked as done (cjs: autopkgtest should be marked as superficial)

Your message dated Fri, 09 Jun 2023 13:03:53 +0000
with message-id <E1q7bmT-004RWX-FM@fasolo.debian.org>
and subject line Bug#1032900: fixed in cjs 5.8.0-1
has caused the Debian Bug report #1032900,
regarding cjs: autopkgtest should be marked as superficial
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1032900: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1032900
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: cjs
Version: 5.6.0-1
Severity: important
Justification: https://release.debian.org/testing/rc_policy.txt 6a
User: debian-ci@lists.debian.org
Usertags: superficial
X-Debbugs-Cc: debian-ci@lists.debian.org

While looking at cjs' test coverage in relation to discussion of mozjs78's
test coverage, I happened to notice that cjs currently has two autopkgtests
enabled:

- "build" is a -dev smoke-test similar to the ones I've been adding to
  various packages, which checks that the -dev package isn't completely
  broken;

- "acc" seems to be doing some sort of ABI validation with
  abi-compliance-checker

These are great to have and I would encourage the maintainers to keep
them, but they don't provide significant test coverage for cjs' C code,
and most functional regressions in cjs or its dependencies wouldn't be
detected by this sort of test.

Please mark these tests with the "superficial" restriction documented
in [0], similar to [1] and [2], so that these tests don't give cjs the
faster migration time that would be used for test suites with significant
coverage.

The Release Team has included this class of issue in their list of
release-critical issues since bullseye[3][4], and has mentioned that the
test must be marked superficial if it is not testing one of the installed
binary packages in some way. As a result, the severity of this bug report
might be increased to serious in future.

If cjs later gains an autopkgtest that *does* have significant test
coverage, for example an equivalent of [5] in gjs (which runs upstream's
"as-installed" test suite as packaged in the gjs-tests), then that one
does not need to be marked as superficial. cjs does have an equivalent
of that test, but it's commented out in debian/tests/control because
there is currently no cjs-tests package.

Please note that [6] (currently also commented out because it fails)
is not considered to be a valid autopkgtest by the release team or by
the autopkgtest spec[0], because it tests a newly-rebuilt copy of cjs,
and not the cjs binaries installed by apt:

    note that the tests must test the *installed* version of the package,
    as opposed to programs or any other file from the built tree
    — [0]

    must test at least one of its own *installed* binary packages
    — [3], [4]; my emphasis

so upstream's test suite can only be used as an autopkgtest if it is
possible to adapt it to do "as-installed" testing of binaries from apt,
for example via GNOME-style installed-tests[7].

    smcv

[0] https://salsa.debian.org/ci-team/autopkgtest/-/blob/master/doc/README.package-tests.rst
[1] https://salsa.debian.org/utopia-team/dbus/-/commit/a80908df7d119b181eec5eb0542634a30c2ad468
[2] https://salsa.debian.org/apparmor-team/apparmor/-/commit/580667513a097088ebe579884b38ac8d8666d3b3,
[3] https://release.debian.org/bullseye/rc_policy.txt
[4] https://release.debian.org/bookworm/rc_policy.txt
[5] https://sources.debian.org/src/gjs/1.74.2-1/debian/tests/installed-tests/
[6] https://sources.debian.org/src/cjs/5.6.0-1/debian/tests/testsuite/
[7] https://wiki.gnome.org/Initiatives/GnomeGoals/InstalledTests

--- End Message ---
--- Begin Message --- 
Source: cjs
Source-Version: 5.8.0-1
Done: Fabio Fantoni <fantonifabio@tiscali.it>

We believe that the bug you reported is fixed in the latest version of
cjs, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1032900@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Fabio Fantoni <fantonifabio@tiscali.it> (supplier of updated cjs package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 09 Jun 2023 14:32:25 +0200
Source: cjs
Architecture: source
Version: 5.8.0-1
Distribution: experimental
Urgency: medium
Maintainer: Debian Cinnamon Team <debian-cinnamon@lists.debian.org>
Changed-By: Fabio Fantoni <fantonifabio@tiscali.it>
Closes: 1032900 1035931
Changes:
 cjs (5.8.0-1) experimental; urgency=medium
 .
   * autopkgtest: marked as superficial (Closes: #1032900)
   * New upstream version 5.8.0 (Closes: #1035931)
   * Various packaging changes for upstream gjs 1.74.2 rebase
   * Update symbols
   * Update breaks to cinnamon 5.6.8
   * Bump Standards-Version to 4.6.2, no changes required
Checksums-Sha1:
 d54bcd969b680ce15a610231a3890be5b2e53f8a 2588 cjs_5.8.0-1.dsc
 20bbf85727a6ec9e11646bb0cfd00084c5501dd9 876305 cjs_5.8.0.orig.tar.gz
 67c92025b8853ca979e6ac925df42ca47a2af706 10184 cjs_5.8.0-1.debian.tar.xz
 ffe546e96ff173f6237edc7eb47100dccd9a8fba 14795 cjs_5.8.0-1_source.buildinfo
Checksums-Sha256:
 5df18a3c037f25495be32a72ec28c20f367069b2a9eba9c726cdeed311a68f6b 2588 cjs_5.8.0-1.dsc
 5a5edddcd422c586d3ece274b457cf2eabb2abd2c6ac7818be0add9144b806e5 876305 cjs_5.8.0.orig.tar.gz
 2a388f89a3f55c64ad1da564d0339c5f817307b30a26c06afe377b01d2205b09 10184 cjs_5.8.0-1.debian.tar.xz
 3ff3d807431aefff544b0ffec6a06a89a8b5304c29ab642c36986820a7d29ab7 14795 cjs_5.8.0-1_source.buildinfo
Files:
 75ba9eae85340b23faed39c966d6fa02 2588 interpreters optional cjs_5.8.0-1.dsc
 8954744bac38caf329dbac152c4f094c 876305 interpreters optional cjs_5.8.0.orig.tar.gz
 6ccb28383e8b786ec0074d465ba79493 10184 interpreters optional cjs_5.8.0-1.debian.tar.xz
 bf30e22b8bb7e0c680b2cbc091077f88 14795 interpreters optional cjs_5.8.0-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEELEHRfLe4S9D5+1GzaAZorpB/EB0FAmSDHXgACgkQaAZorpB/
EB2yRRAAjFuX1KB4TtbNeGMlicFh3coQt0Jd86nSXexALJEYJpxFCN0S3NH3D6EX
nck2u5VHSnMSqt1n6iiOTXmG32uEbH2RgQrUrvlh3Tfqv6OZxG9Gg3k6gUOmu+od
MA6/IEVAYkrmccxQQGcHhAZXSBfuG0OMpu8KAfPtNUQuolHrSENoS2lR0XrJYB/N
6qec33DFrbGkrKl4XvFeHWvg4JbN3Izh0pFOAofP6XOlLIlxSCoAeAyF2pDaXH4t
tFvFe+cxc+n42yTfTJjgruTLoUDB/KInKPFp9wv6Lpb7nBME9sbUU8ww08XIfMZ/
fxVlZ15HicjrNagIE3ZA91F0+1YPAm0Hz/0I14PIKNFwFIkVb9hLKJekOfaE+fU+
6JtzIwuSJMLc8Oj7AdxTRlNgM24G8hGGpcMPwtekPRkYx6/zRYBHdlQyRl4DuMxy
c8CrOa/eSe9Cbw8E90M95UOq+zD76li95SAP7bCsJ1wmJXhoh/mzg+S/breuNc4V
N4S83pKfdECdVDoouTYp6tHteDK9VNbqPmMNbipS3BJa6HfRhTDijXyJ9CPBXX5V
N1v9+QxuaPqcyrm+2KGqEBCU1v9kowjkrrhhSm/caGlkcUwL5cc4AxOf6HOuKoO8
HMeGbLHXQ04llmESu0nW3KXV9/W+gy5p7j1IQ3eLe5PHXdbSPuo=
=r6dy
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: