|
>
I cannot align the comments from Adrian with all the rest of discussions. I can add missing B-Ds if this is actually the case, but I don't see this problem in my clean chroot builds. (At least the last time I checked).
Yes. It does build fine... but for Debian and somehow in Ubuntu.
The thing is, for Ubuntu 20.10 and 20.04 on MY sbuilds they aren't working, they fail
> And adding dh_auto_conifugure overrides doesn't seem like a good idea if the builds are actually succeeding.
Not all of them are and I'm sure soon they will encounter this error. Even LM did they simple change of just adding --Wno-error.
>
first of all it would be nice to hear **which** version of cjs did **not** build on **which** version of Ubuntu, including a full log file/terminal output.
Versions: I found 20.04 and 20.10 not working. This is cjs version 4.6.0-2.
> Then, if this is only a problem in Ubuntu, I need some good explanation why we should hack around something that only breaks in Ubuntu.I think it probably will, or has happened in Debian already. If it can't run with latest I don't have any idea what could be missing as I checked the build dependency trackers and they are up-to-date.
It doesn't hurt to add it. LM probably added it in there for a reason. Overall I see no reason to not add this patch as it was done in LM to fix their build. We should probably do the same, until they update their code to remove GParameters.
|