Re: Cinnamon 4.2, salsa and master branch
close 825756
thanks
Hi Fabio, hi Max,
thanks for the reviews.
On Sun, 01 Sep 2019, Fabio Fantoni wrote:
> cjs:
> - upstream added libxml2-utils as missed build-dep, need to be checked
> if really needed and if yes add it:
> https://github.com/linuxmint/cjs/commit/ea081f3272d5dfb78eceef47826acf90db5d4bdd#diff-6e9552c9bd8e61c8f277c21220160234
I could build in a clean chroot without explicitely adding it.
Just now retested it.
> - these symbols missed in 4.2 seems strange:
> https://salsa.debian.org/cinnamon-team/cjs/commit/04d50b7e8fecf97a7bff0654028e76d7a6392259
> cjs 4.0->4.2 are near nothing and I didn't saw nothing that can remove
> that symbols from a fast look, and even if really removed the lines
> should be removed, or I'm wrong?
> @Maxy: can you take a look to this please?
I have no idea. I used the tool Max recommended me and the outcome was
this file.
> muffin:
> 4.2 changes look ok except symbols keeped commented that not seems good
See above, same.
> nemo-fileroller
> no real change from upstream 4.0->4.2 but only version increase for all
Yes, still for consistency reason I think it is better to keep the same
versioning as upstream.
> Relooking upstream about it:
> https://github.com/linuxmint/cinnamon-menus/commit/efebe9a1d78ee4bc827c91025d81d41bc7741730
> docs was added in -dev package and is only for developers
>
> @Maxy: is really needed split to another package in debian? adding also
> another difference/conflict with upstream :(
I think adding the docs to the -dev packages is enough.
> cinnamon-session
> from fast look seems ok
> @Norbert: any news about this?
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=825756
Closing it with this email - I completely forgot about it and I don't
see the problem anymore.
> I also saw that cjs 4.0 failed to build on some archs for symbols issue
> but I didn't know how to optimally manage the special cases of debug
> symbols in order to avoid problems like those :(
> For example:
> https://buildd.debian.org/status/fetch.php?pkg=cjs&arch=armhf&ver=4.0.0-1&stamp=1567096183&raw=0
I think these are the same MISSINGs that we have now in 4.2?
Best
Norbert
--
PREINING Norbert http://www.preining.info
Accelia Inc. + IFMGA ProGuide + TU Wien + JAIST + TeX Live + Debian Dev
GPG: 0x860CDC13 fp: F7D8 A928 26E3 16A1 9FA0 ACF0 6CAC A448 860C DC13
Reply to: