[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#580372: libbsd0: Makefile needs a small fix?

On Sun, 16 May 2010, Thorsten Glaser wrote:

> Cristian Ionescu-Idbohrn dixit:
> >What I have in mind is attached.
> Two comments:
> * The changes to the comments in libbsd-0.2.0.cii0/Makefile are… weird,e
>   especially in the ifeq case.

Could you please be more specific?

> * Do not use $(shell ./foo.sh), use $(shell sh foo.sh) instead, which
>   does not rely on the +x attribute (bad thing) and possibly saves
>   one invocation.

I just kept the same style as used at the top of that Makefile:

	VERSION := $(shell ./get-version)


Reply to: