[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [patch] netcfg get_all_ifs()

On 06/07/2009, Luca Favatella <slackydeb@gmail.com> wrote:
> On 06/07/2009, Frans Pop <elendil@planet.nl> wrote:
>> On Monday 06 July 2009, Luca Favatella wrote:
>>> This patch substitutes Linux-specific code in get_all_ifs() using
>>> getifaddrs().
>> -        if (!strcmp(ibuf, "lo"))        /* ignore the loopback */
>> [...]
>> +        if (!strncmp(ibuf, "lo", 2))        /* ignore the loopback */
>> Please do not include random changes that are unrelated to what you
>> document in the changelog in the patch. This _does_ change functionality,
>> even if in practice it will not make a difference.
>> The old code would not match on an (unlikely) interface named "loop", the
>> new code will.
>> Cheers,
>> FJP
> Solved in the attached version 2 of the patch.

I'm not committing this to trunk because could affect d-i on Linux
(not in my test).

Should I commit this?

Luca Favatella

Reply to: