[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] various os-prober patches



Hi Holger,

Holger Wansing <hwansing@mailbox.org> (2020-04-03):
> Luckily, covid-19 generates some spare time here, since I was directed
> to stay at home from work :-) 
> (No personal covid-19 infection here, though. All in family are fine.)

Great news, best of luck to everyone out there!

> I wonder if we would want to apply all those changes in one os-prober
> version or split that into some parts (to ease debugging, if problems
> appear)...
> 
> I played around with that patches a bit, and 8 of them no longer apply
> cleanly (maybe they are somewhat old, and code has changed in the
> meantime).
> 
> Moreover, there are 4 patches which conflict with others.
> 
> So, if I leave those 12 patches out for now, that would give 15
> patches, which could be cleanly applied. Would that be a reasonable
> plan for the first round?
> 
> Is some sort of review wanted before commit?

I suppose it would make sense to sanity-check all patches to see if they
indeed do make sense in Debian (after all some might be really needed
for downstreams only, and could/should be made conditional or
something).

Feel free to push a branch / open a MR with the whole series that
applies cleanly, so that someone can look over them (maybe I'll be able
to do, maybe someone else)?


Cheers,
-- 
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

Attachment: signature.asc
Description: PGP signature


Reply to: