[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#877735: marked as done (busybox: m68k build broken due to "-Os" in CFLAGS)

Your message dated Wed, 1 Aug 2018 19:28:13 +0200
with message-id <b847152b-0891-3fb1-4b33-3a85ceabf86c@physik.fu-berlin.de>
and subject line Re: Bug#877735: busybox: m68k build broken due to "-Os" in CFLAGS
has caused the Debian Bug report #877735,
regarding busybox: m68k build broken due to "-Os" in CFLAGS
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
877735: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=877735
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: busybox
Version: 1:1.27.2-1
Severity: important
User: debian-68k@lists.debian.org
Usertags: m68k

Hi!

Thanks for picking up the maintainership for busybox!

Unfortunately, one of the changes introduced with the new package
causes breakage on m68k with the built-in shell no longer working
properly:

Version 1:1.22.0-17:

root@pacman:~# busybox |head
BusyBox v1.22.1 (Debian 1:1.22.0-17) multi-call binary.
BusyBox is copyrighted by many authors between 1998-2012.
Licensed under GPLv2. See source distribution for detailed
copyright notices.

Usage: busybox [function [arguments]...]
   or: busybox --list[-full]
      or: busybox --install [-s] [DIR]
         or: function [arguments]...

root@pacman:~# busybox ash -c 'echo ${x}'

root@pacman:~#

----------------------------------------------------------

Version 1:1.27.2-1:

root@pacman:~# busybox |head
BusyBox v1.27.2 (Debian 1:1.27.2-1) multi-call binary.
BusyBox is copyrighted by many authors between 1998-2015.
Licensed under GPLv2. See source distribution for detailed
copyright notices.

Usage: busybox [function [arguments]...]
   or: busybox --list[-full]
      or: busybox --install [-s] [DIR]
         or: function [arguments]...

root@pacman:~# busybox ash -c 'echo ${x}'
ash: syntax error: missing '}'
root@pacman:~#

----------------------------------------------------------

After some fiddling, I found out that the culprit is the -Os
which is now in CFLAGS. Reverting the change from [1] fixes
the problem:

root@pacman:~# busybox |head
BusyBox v1.27.2 (Debian 1:1.27.2-1) multi-call binary.
BusyBox is copyrighted by many authors between 1998-2015.
Licensed under GPLv2. See source distribution for detailed
copyright notices.

Usage: busybox [function [arguments]...]
   or: busybox --list[-full]
      or: busybox --install [-s] [DIR]
         or: function [arguments]...

root@pacman:~# busybox ash -c 'echo ${x}'

root@pacman:~#

----------------------------------------------------------

Since busybox is very important to boot the system and get
debian-installer working, I would like to ask to have the
change from [1] reverted for m68k until we have fixed the
potential bug in gcc which most likely mis-compiled busybox.

Thanks,
Adrian

> [1] https://anonscm.debian.org/cgit/d-i/busybox.git/commit/?id=8a115a910fb3cd7a525972e150a32f8aeb1da492

--
  .''`.  John Paul Adrian Glaubitz
 : :' :  Debian Developer - glaubitz@debian.org
 `. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

--- End Message ---
--- Begin Message --- 
Hello!

On 10/05/2017 01:16 AM, John Paul Adrian Glaubitz wrote:
> Since busybox is very important to boot the system and get
> debian-installer working, I would like to ask to have the
> change from [1] reverted for m68k until we have fixed the
> potential bug in gcc which most likely mis-compiled busybox.

I have just done a testbuild of the current busybox package with
the new default gcc-8 and I can confirm the problem no longer exists,
busybox works correctly again, without any modifications:

root@pacman:~# busybox | head
BusyBox v1.27.2 (Debian 1:1.27.2-3) multi-call binary.
BusyBox is copyrighted by many authors between 1998-2015.
Licensed under GPLv2. See source distribution for detailed
copyright notices.

Usage: busybox [function [arguments]...]
   or: busybox --list[-full]
   or: busybox --install [-s] [DIR]
   or: function [arguments]...

root@pacman:~# busybox ash -c 'echo ${x}'

root@pacman:~#

I have also unblocked the busybox package on the buildds.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

--- End Message ---
Reply to: