[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#609476: marked as done (installation-reports: Insufficient care in pre-install script risks bricking Linkstation)



Your message dated Mon, 14 Mar 2011 22:05:17 +0000
with message-id <E1PzFt7-0003jn-3Y@franck.debian.org>
and subject line Bug#609476: fixed in debian-installer 20110106+squeeze1
has caused the Debian Bug report #609476,
regarding installation-reports: Insufficient care in pre-install script risks bricking Linkstation
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
609476: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=609476
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: installation-reports
Severity: critical
Tags: patch
Justification: breaks the whole system

I attempted to install Debian squeeze on my Buffalo Linkstation Live
(LS-CHLv2), as per guidance at
<http://buffalo.nas-central.org/wiki/Install_Debian_on_the_Linkstation_Pro/Live>.
Ultimately I failed, but this report concerns one serious issue encountered on
the way.

The daily snapshots linked from <http://www.debian.org/devel/debian-installer/>
include this script:
<http://people.debian.org/~joeyh/d-i/armel/images/daily/orion5x/network-console/buffalo/lspro/config-debian>
intended to prepare the system for reboot into the Debian kernel.  One of the
ways in which this script can fail is that the buffalo version is not fetched
from the environment.  However, in this case the script does not exit and
proceeds to attempt to modify the environment.  If the users /etc/fw_env.config
is incorrect (as mine was) then this attempt to fetch the version will fail,
and the subsequent modification of the environment might modify an arbitrary
portion of the system's flash memory, potentially rendering it unbootable.
Luckily I noticed this issue when fw_printenv failed for other reasons, and
fw_setenv failed also.

I propose adding an "exit 1" to the script after the error message related to
this issue.  For completeness, I would also recommend exiting from the script
if the attempt to back up the pre-existing environment fails.  The attached
patch to config-debian includes both changes.

-- System Information:
Debian Release: 5.0.7
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: armel (armv5tejl)

Kernel: Linux 2.6.22.18-88f6281
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
--- config-debian	2011-01-09 11:39:49.000000000 +0000
+++ config-debian.new	2011-01-09 18:36:54.143989487 +0000
@@ -43,21 +43,22 @@
 fi
 
 BOOTVER=$($GETENV buffalo_ver | sed 's/^.*=//')
 if [ -z "$BOOTVER" ]; then
 	echo "Unable to detect Buffalo bootloader version.  Please ensure that your bootloader supports automatic initrd position/size detection."
+	exit 1
 else
 	BOOTVER_MAJOR=${BOOTVER%.*}
 	BOOTVER_MINOR=${BOOTVER#*.}
 	if [ $BOOTVER_MAJOR -eq 1 -a $BOOTVER_MINOR -lt 10 ]; then
 		echo "Incompatible bootloader version detected.  Please update to the latest firmware version."
 		exit 1
 	fi
 fi
 
 printf "Saving U-Boot environment to ubootenv.bak... "
-$PRINTENV > ubootenv.bak
+$PRINTENV > ubootenv.bak || exit 1
 echo "done."
 
 echo "Changing U-Boot environment... "
 $SETENV bootargs_root "root=/dev/sda2 rw panic=5"
 echo "done."

--- End Message ---
--- Begin Message ---
Source: debian-installer
Source-Version: 20110106+squeeze1

We believe that the bug you reported is fixed in the latest version of
debian-installer, which is due to be installed in the Debian FTP archive:

debian-installer-images_20110106+squeeze1_amd64.tar.gz byhand
debian-installer_20110106+squeeze1.dsc
  to main/d/debian-installer/debian-installer_20110106+squeeze1.dsc
debian-installer_20110106+squeeze1.tar.gz
  to main/d/debian-installer/debian-installer_20110106+squeeze1.tar.gz
debian-installer_20110106+squeeze1_amd64.deb
  to main/d/debian-installer/debian-installer_20110106+squeeze1_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 609476@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Julien Cristau <jcristau@debian.org> (supplier of updated debian-installer package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 13 Mar 2011 21:31:36 +0100
Source: debian-installer
Binary: debian-installer
Architecture: source amd64
Version: 20110106+squeeze1
Distribution: squeeze
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Julien Cristau <jcristau@debian.org>
Description: 
 debian-installer - Debian installer
Closes: 609476 610906
Changes: 
 debian-installer (20110106+squeeze1) squeeze; urgency=low
 .
   [ Jurij Smakov ]
   * Add pata-modules to cdrom config for sparc and sparc64.
     Closes: #610906.
 .
   [ Martin Michlmayr ]
   * qnap-flash-debian: recognize QNAP TS-x12 devices.
   * lspro-config-debian: Exit if the firmware version cannot be
     determined.  Thanks John Bytheway.  Closes: #609476
Checksums-Sha1: 
 40096434739c9f61c50c991712dd832d90c15ffd 3306 debian-installer_20110106+squeeze1.dsc
 6109aa6f46cd78f13d6064d576c885de1f1bb88d 1365069 debian-installer_20110106+squeeze1.tar.gz
 55eaba68b0fa6d02025ad1af57cb02b9a6f2ba9b 820300 debian-installer_20110106+squeeze1_amd64.deb
 24d98c60d79fc0978ddc5a4d3d23f2e36d2ce03d 174172649 debian-installer-images_20110106+squeeze1_amd64.tar.gz
Checksums-Sha256: 
 17564d4ecdee56a7b5f3b6477abc0335e4d6604786f47f1943ec1b4d745bdc2e 3306 debian-installer_20110106+squeeze1.dsc
 c9c8251b35ec34c7cd269609ee2a96717aca88f8ec67a350ae060f464f22fab0 1365069 debian-installer_20110106+squeeze1.tar.gz
 75109e4bb1d122cf7b8b4d279e9be2441558e4b34f5b9c27e33e8d269a08d1ba 820300 debian-installer_20110106+squeeze1_amd64.deb
 24ca2a66312f30c5fdafd50982bc0920a9ae715973ee755be07e0dbd838219b4 174172649 debian-installer-images_20110106+squeeze1_amd64.tar.gz
Files: 
 88edd2087f2ce48b7b5cb93daa578ac7 3306 devel optional debian-installer_20110106+squeeze1.dsc
 1b5f945f5d109dfc9f3e841224a516bd 1365069 devel optional debian-installer_20110106+squeeze1.tar.gz
 26f47712da18f3480d11e3667d1a7a3b 820300 devel optional debian-installer_20110106+squeeze1_amd64.deb
 6b4e68fc1f979dd7147fc49c69b970e0 174172649 raw-installer - debian-installer-images_20110106+squeeze1_amd64.tar.gz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBCAAGBQJNfUnTAAoJEDEBgAUJBeQM7zsP/21wJos3i8/tqRWGbPBZlpvB
eR7z0yGJSivFUoAx3lF+lbBvTUMtR8jfuioO6qq6R0r7tQaRkuaggQXLKX++GaxD
/+vzEM9PwKZ7WF+fcBaOhB1WBZlzb4NvmMK3fevTEBeVb+WxNE9VPtYlFUzxtQ39
ykKKo/XN69sJxU7Rv1lCyNHBdbbygsokM8eUZqpPnMgu07Sx5P5iRtRSO5LXHEln
IqejjZxA4i7PZZ0HF82BNgKxSGuUxO39HSVYSlJb8Ki5kqcBvhPbBseGbXozewXx
Nv7Jx1XYwmwHSytF8zjXoAqytpm4YuXL+CdkkShyybA6aIGecsLIBiMef/daVIDc
MHmNRDyRohcGpHrPP+l2zHPWgTYrt3Rd+SYDTHd61wHSA0YOcp9YjUdsVWNAGdIh
sdDuH9A99tZPX5mEPS9lcLdtDymm/JDS0gaRZ5Okq3RvOoH8wgmIngqmDMORHYWk
EIfhpfoan/wwRX6HRSUsSPc+Kogh5Eto19WOgxU1tBHjKX2e5c2YQ41/XaFPFcl3
EzIVsLZsuKpShBEm9Jej7xLFixIumReX/Yi03QJp545sAUWTKl2quzGHzFLOkuFC
yu8tIgEmhxoqtAmuJFJi/++NzbP5LRWB9cMAphDy+2OgyocHdH5rTF7gdHqrDGmb
1gn2RYsLx7T/JhUHgH+F
=LK8w
-----END PGP SIGNATURE-----



--- End Message ---

Reply to: