[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#561298: marked as done (debootstrap: download_main fails to iterate through components)



Your message dated Mon, 22 Feb 2010 03:34:07 +0000
with message-id <E1NjP3f-0003Q9-7o@ries.debian.org>
and subject line Bug#561298: fixed in debootstrap 1.0.21
has caused the Debian Bug report #561298,
regarding debootstrap: download_main fails to iterate through components
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
561298: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=561298
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: debootstrap
Version: 1.0.20
Tags: patch

There's a bug in the following code in download_main.  I've left
comments in the code below describing it:

# Let's assume $p contains 'coreutils' for this explanation..
# $COMPONENTS contains at least 2 entries (ie, "foo bar")
            for c in $COMPONENTS; do
                local details=""
# $details contains ""
                for m in $MIRRORS; do
                        local path="dists/$SUITE/$c/binary-$ARCH/Packages"
                        local pkgdest="$TARGET/$($DLDEST pkg "$SUITE" "$c" "$ARCH" "$m" "$path")"
                        if [ ! -e "$pkgdest" ]; then continue; fi
                        details="$($PKGDETAILS PKGS "$m" "$pkgdest" "$p")"
# $details contains "coreutils -" if the package wasn't found in component 'foo'.
                        if [ "$details" = "$p -" ]; then continue; fi
# Assuming only 1 entry in $MIRRORS, break out of the loop..
...
                done
# At this point, $details contains "coreutils -"
                if [ "$details" != "" ]; then
                        break
# Whoops, coreutils wasn't actually found in 'foo'; it's actually in 'bar'.
# But since $details contains something other than "", we break out of
# the $COMPONENTS loop!  Debootstrap then fails, because coreutils couldn't
# be downloaded.
                fi
            done


This bug is only triggered when you have multiple COMPONENTS, which is
presumably why no one else has hit this (see bug #561283, which allows
usage of multiple components w/ mirror_style main).

The patch below fixes this issue.



--- /usr/share/debootstrap/functions.bak	2009-12-15 16:57:03.000000000 -0500
+++ /usr/share/debootstrap/functions	2009-12-15 19:23:57.000000000 -0500
@@ -685,7 +685,10 @@
 			local pkgdest="$TARGET/$($DLDEST pkg "$SUITE" "$c" "$ARCH" "$m" "$path")"
 			if [ ! -e "$pkgdest" ]; then continue; fi
 			details="$($PKGDETAILS PKGS "$m" "$pkgdest" "$p")"
-			if [ "$details" = "$p -" ]; then continue; fi
+			if [ "$details" = "$p -" ]; then
+				details=""
+				continue
+			fi
 			size="${details##* }"; details="${details% *}"
 			md5="${details##* }"; details="${details% *}"
 			local debdest="$($DLDEST deb $details)"





--- End Message ---
--- Begin Message ---
Source: debootstrap
Source-Version: 1.0.21

We believe that the bug you reported is fixed in the latest version of
debootstrap, which is due to be installed in the Debian FTP archive:

debootstrap-udeb_1.0.21_all.udeb
  to main/d/debootstrap/debootstrap-udeb_1.0.21_all.udeb
debootstrap_1.0.21.dsc
  to main/d/debootstrap/debootstrap_1.0.21.dsc
debootstrap_1.0.21.tar.gz
  to main/d/debootstrap/debootstrap_1.0.21.tar.gz
debootstrap_1.0.21_all.deb
  to main/d/debootstrap/debootstrap_1.0.21_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 561298@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Otavio Salvador <otavio@debian.org> (supplier of updated debootstrap package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 21 Feb 2010 23:11:06 -0300
Source: debootstrap
Binary: debootstrap debootstrap-udeb
Architecture: source all
Version: 1.0.21
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Otavio Salvador <otavio@debian.org>
Description: 
 debootstrap - Bootstrap a basic Debian system
 debootstrap-udeb - Bootstrap the Debian system (udeb)
Closes: 288109 345762 390647 458663 557296 561283 561298
Changes: 
 debootstrap (1.0.21) unstable; urgency=low
 .
   [ Otavio Salvador ]
   * Apply patch from Clint Adams <schizo@debian.org> to add support for
     gz/bz2/xz data.tar (closes: #458663).
 .
   [ Guillem Jover ]
   * Refactor deb extractors into two new functions.
   * Use dpkg-deb if available instead of ar (closes: #557296).
   * Add an --extractor option to override the automatic extractor selection.
 .
   [ Otavio Salvador ]
   * Document new --extractor option in manpage.
   * Apply patch from Vagrant Cascadian <vagrant+bugs@freegeek.org> not
     fail if resolv.conf is a broken symlink (closes: #390647).
 .
   [ Frans Pop ]
   * Use tab indentation in scripts/debian/sid to reduce its size (relevant
     for Debian Installer).
   * Add apt to base packages for the buildd variant as it is no longer marked
     Build-Essential.
 .
   [ Otavio Salvador ]
   * Apply patch from Andres Salomon <dilinger@collabora.co.uk> to honor
     --components when using mirror_style 'main' (closes: #561283).
   * Apply patch from Andres Salomon <dilinger@collabora.co.uk> to fix
     iteration through components in download_main (closes: #561298).
 .
   [ Joey Hess ]
   * Allow the suite to be stable, testing, or unstable when debootstrapping
     Debian. Closes: #288109
   * Make scripts directory in source tree look like installed directory,
     and add a section to README explaining an easy way to run
     debootstrap w/o installing it. Closes: #345762
   * Convert rules file to use dh with overrides.
   * Remove binary-basedebs target from debian/rules.
     This target has been broken in multiple ways since 2007. While I
     accidentially partially fixed it with the above changes, this is evidence
     it's dead code that can be safely removed.
Checksums-Sha1: 
 4210e7b38b194f2edf5b250d3b4c4a5361c0a3b5 1669 debootstrap_1.0.21.dsc
 55e151a851c25cd82f0bede60ee6d5bd140223dc 56841727 debootstrap_1.0.21.tar.gz
 5a71a47a1183ae096f377eeb90900899907cf589 57042 debootstrap_1.0.21_all.deb
 785919c500862fc28d184eb5d59bdf9393786339 18886 debootstrap-udeb_1.0.21_all.udeb
Checksums-Sha256: 
 9852140ec9dae3df6f824cfe98b2e84089b5ef6b9487ca318e44164fee47c782 1669 debootstrap_1.0.21.dsc
 fd0f2a92f9706a7b52935fc988b84d6678173cbffd14b0ea84f43335e665a303 56841727 debootstrap_1.0.21.tar.gz
 be2bc42919796889d0b3110a919b9aa69c9c5e1974574994fd128938c5c22893 57042 debootstrap_1.0.21_all.deb
 73a234f2e3e6907b8eea6e9f7b4372bfe042ef9bf61924751519b599e7edf3e0 18886 debootstrap-udeb_1.0.21_all.udeb
Files: 
 5d54eba945bfb7f14fcb4cc892a1b828 1669 admin extra debootstrap_1.0.21.dsc
 90c8e02b41ef73b8a5dc774d5a546635 56841727 admin extra debootstrap_1.0.21.tar.gz
 c486ada83c35d46152beb9d30aa98d08 57042 admin extra debootstrap_1.0.21_all.deb
 204318870f77f3511078f08d743b78c4 18886 debian-installer extra debootstrap-udeb_1.0.21_all.udeb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBCAAGBQJLgef+AAoJEOtw/vPN/G5PbVcP/1vCc2zd0Ii6VcPlOYxolzqt
2uQgFN4XFbghO35d5HC7qpfMWpNE43lGg/L4rB2kRbj94Amm/55o5BSi+Q98n95D
m/YwUxq59GsG7RQVQzbmCHvcwBU2Tqf1D0ejr0sX8DCA42B3OZ03NvqI5UsTUmA8
Pdc8ZabeK2elPW2cx+conMpIeE247TeeQY56oYWePd3FNht0RMY+jGBJb8LwifRP
urCGHtofLPlDfnnALt4e3+YcoPym0KdTM/R/AxAAMGAyN+zwaQXrvj9kyKJYA9ew
ckCaBAjpnNfUuIQlKFWK5TwZudo5hIrK4WnspfDPyQDXoVt2hEaTC8lpfv2JCCLh
k2kZK14BLN/ikAwFGLw+RN3kcwWXa1Oz2RkBCu0tAR8VZQAKMIqM8IpJzTMs2wHQ
oJCrITxrF7tXmkbFc5CAlwB/FyhuK8LoG+VSOSKNagDvCzYfyN2W4x4QbmwVr8+C
iaWqheOiRn3xesKJSSBE5lJtx/lj212i4M5vEB49g+9wbpLnJCThIax/Mj5DEA7k
12K420nr9nEUd/X7wS5EdtjICpDjL/Af3OuVmfqFFo+bcOVJi97el6SwAkd7Opth
j5cOnLQLmhOd5b6iYB0OkH/va73fWPb0gEFYRSpcsJM4UFzc23ZN/uwfgZjSNRxD
PX1xtc0L0D+QC9WcQ4EA
=IJqM
-----END PGP SIGNATURE-----



--- End Message ---

Reply to: