[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Review of console-setup wrt D-I



On Sat, Jun 27, 2009 at 11:09:39PM +0200, Frans Pop wrote:
> > Setupcon is actually used.  This script defines its own version of
> > which and gzip is used only if it is installed (so it is not used in
> > d-i).
> 
> Maybe, but you test for its existence using 'which'. D-I busybox does not 
> have that => script errors.

It is true that it is better to use 'type' instead of 'which' but the 
current method also works - setupcon defines 'which' as internal 
function so the external 'which' is never used even if it exists.

Anton Zinoviev


Reply to: