Re: [PATCHv3] Make syslinux beep
Otavio Salvador, le Wed 20 Aug 2008 15:40:09 -0300, a écrit :
> Samuel Thibault <samuel.thibault@ens-lyon.org> writes:
> > Samuel Thibault, le Wed 13 Aug 2008 01:39:31 +0100, a écrit :
> >> Frans Pop, le Wed 13 Aug 2008 02:05:45 +0200, a écrit :
> >> > Better to just use 0/1 as values and only test for '= 1' (or test for
> >> > set/unset, not sure what is more common).
> >>
> >> At least DEBUG uses y/n, so I have done the same in the attached fixed
> >> patch.
> >
> > ping?
>
> Hello Samuel,
>
> It looks OK for me. What is you alioth login? I think it is
> 'sthibaul-guest' but wanted to be sure before adding you on the
> project.
>
> Obviously, you should still send the patches for review on the mailing
> list before commiting them but it makes easier for you to be able to
> commit your changes.
Oh, I wasn't expecting to commit it myself, but why not. Yes, it is
sthibaul-guest.
Samuel
Reply to: