[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [patch] Add support for Kurobox Pro to Debian Installer



On Wednesday 16 July 2008, Per Andersson wrote:
> The adding of jffs2 to i386 is not related to Kurobox Pro
> support, only done by request. [0]

However, I'm not sure that is sufficient reason to add the udeb for i386 
now. I have not yet seen any concrete mails or proposals for supporting 
XO in the installer, just "vague" mails saying that it would be nice to 
have.

We can easily add it when it's actually going to be used, so my preference 
would be to just leave it until then. That will at least save us 
unnecessary NEW processing with the next upload.

> Attached patches:
> 0000
>   Adds support for Kurobox Pro to flash-kernel
> 0001
>   Adds support for Kurobox Pro to oldsys-preseed, needs
>   jffs2-modules to work (see 0003)
> 0002
>   Adds tests for Kurobox Pro to oldsys-preseed.

No comment. Should be reviewed by Martin.

> 0003
>   Adds support for jffs2 modules to kernel-wedge, needed
>   by oldsys-preseed on Kurobox Pro. Also requested to
>   support OLPC XO.

Looks good. You've also got the package description now.

> 0004
>    Adds jffs2 modules to armel-orion5x, needed by
>    oldsys-preseed on Kurobox Pro, and to i386,
>    to support OLPC XO (requested). [0]

See how simple this is now?
Looks good but please drop i386 as explained above.

0003 and 0004 could be committed in a single commit (with appropriate 
changelog entries of course).

> 0005
>    Adds build options and flash-debian script to d-i to
>    support Kurobox Pro.

+++ b/installer/build/boot/arm/kuroboxpro-flash-debian
Please be consistent in your indentation. Some lines use spaces.
No comment on logic. Should be reviewed by Martin.

> kuroboxpro_dhcp.tgz
> kuroboxpro_static.tgz
>    Archives of files used by Kurobox Pro tests in
>    oldsys-preseed.

No comment.

Cheers,
FJP

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: