[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#230598: marked as done (prebaseconfig: Should show progress info while running scripts)



Your message dated Sat, 14 Feb 2004 14:02:03 -0500
with message-id <E1As53D-0000Zt-00@newraff.debian.org>
and subject line Bug#230598: fixed in prebaseconfig 0.52
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 1 Feb 2004 09:22:05 +0000
>From pre@saruman.uio.no Sun Feb 01 01:22:05 2004
Return-path: <pre@saruman.uio.no>
Received: from pat.uio.no [129.240.130.16] (7411)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1AnDno-00078L-00; Sun, 01 Feb 2004 01:22:05 -0800
Received: from mail-mx2.uio.no ([129.240.10.30])
	by pat.uio.no with esmtp (Exim 4.20)
	id 1AnDni-0007fH-SN
	for submit@bugs.debian.org; Sun, 01 Feb 2004 10:21:58 +0100
Received: from saruman.uio.no ([129.240.201.202])
	by mail-mx2.uio.no with esmtp (Exim 4.14)
	id 1AnDnf-0006Pa-N6; Sun, 01 Feb 2004 10:21:55 +0100
Received: from pre by saruman.uio.no with local (Exim 2.12 #7)
	id 1AnDnf-0005Sl-00; Sun, 1 Feb 2004 10:21:55 +0100
To: submit@bugs.debian.org
Subject: prebaseconfig: Should show progress info while running scripts
From: Petter Reinholdtsen <pere@hungry.com>
Message-Id: <E1AnDnf-0005Sl-00@saruman.uio.no>
Sender: Petter Reinholdtsen <petter.reinholdtsen@usit.uio.no>
Date: Sun, 1 Feb 2004 10:21:55 +0100
X-MailScanner-Information: This message has been scanned for viruses/spam. Contact postmaster@uio.no if you have questions about this scanning
X-UiO-MailScanner: No virus found
X-UiO-Spam-info: not spam, SpamAssassin (score=0, required 12)
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_01_27 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-5.0 required=4.0 tests=HAS_PACKAGE autolearn=no 
	version=2.60-bugs.debian.org_2004_01_27
X-Spam-Level: 


Package:  prebaseconfig
Version:  0.50
Severity: minor
Tags:     d-i

At the moment, prebaseconfig execute the script fragments in complete
silence.  If this take some time, the user experience a empty blue
screen in this period.  This is confusing and annoying.  I suggest
adding a progress bar to prebaseconfig.

I started coding, and believe the implementation is complete, but I
haven't been able to find time to test it.  Because of this, I post
the patch into BTS, and hope someone else can find time to test the
patch.  If it work, the bug should be tagged 'patch', and the patch
commited to CVS.

Index: debian/changelog
===================================================================
RCS file: /cvsroot/d-i/debian-installer/tools/prebaseconfig/debian/changelog,v
retrieving revision 1.190
diff -u -3 -p -u -r1.190 changelog
--- debian/changelog	29 Jan 2004 15:26:24 -0000	1.190
+++ debian/changelog	1 Feb 2004 09:18:32 -0000
@@ -12,6 +12,8 @@ prebaseconfig (0.51) UNRELEASED; urgency
     - Update Swedish translation sv.po
   * Jordi Mallach
     - Update Catalan translation (ca.po).
+  * Petter Reinholdtsen
+    - Show progress info when executing the prebaseconfig parts.
 
  -- Joey Hess <joeyh@debian.org>  Sun, 11 Jan 2004 17:53:30 -0500
 
Index: debian/postinst
===================================================================
RCS file: /cvsroot/d-i/debian-installer/tools/prebaseconfig/debian/postinst,v
retrieving revision 1.32
diff -u -3 -p -u -r1.32 postinst
--- debian/postinst	7 Nov 2003 15:20:09 -0000	1.32
+++ debian/postinst	1 Feb 2004 09:18:32 -0000
@@ -1,5 +1,7 @@
 #! /bin/sh
 
+. /usr/share/debconf/confmodule
+
 set -e
 
 log() {
@@ -10,8 +12,16 @@ log() {
 # parts will unmount /target/
 run_parts() {
     partsdir="$1"
+    scriptcount=`ls "$partsdir"/* | wc -l`
+
+    db_progress START 0 $scriptcount prebaseconfig/runparts-progress/title
+
     tmpfile=/tmp/prebaseconfig.stderr.log
     for script in "$partsdir"/*; do
+
+	db_subst prebaseconfig/runparts-progress/step SCRIPT "$script"
+	db_progress INFO prebaseconfig/runparts-progress/step
+
         if [ -x "$script" ] ; then
             log "info: Running $script"
             if "$script" 2> $tmpfile ; then
@@ -26,7 +36,10 @@ run_parts() {
         else
             log "error: Unable to execute $script"
         fi
+
+	db_progress STEP 1
     done
+    db_progress STOP
 }
 
 run_parts /usr/lib/prebaseconfig.d
Index: debian/templates
===================================================================
RCS file: /cvsroot/d-i/debian-installer/tools/prebaseconfig/debian/templates,v
retrieving revision 1.9
diff -u -3 -p -u -r1.9 templates
--- debian/templates	17 Nov 2003 04:22:37 -0000	1.9
+++ debian/templates	1 Feb 2004 09:18:32 -0000
@@ -16,9 +16,17 @@ _Description: System reboot
  .
  Please take care of all that before you continue.
 
-Template: prebaseconfig/progress/title
+Template: prebaseconfig/reboot-progress/title
 Type: text
 _Description: Rebooting the system
+
+Template: prebaseconfig/runparts-progress/title
+Type: text
+_Description: Finishing up the first part of the installer
+
+Template: prebaseconfig/runparts-progress/step
+Type: text
+_Description: Running script ${SCRIPT}
 
 Template: debian-installer/prebaseconfig/title
 Type: text
Index: prebaseconfig.d/99reboot
===================================================================
RCS file: /cvsroot/d-i/debian-installer/tools/prebaseconfig/prebaseconfig.d/99reboot,v
retrieving revision 1.8
diff -u -3 -p -u -r1.8 99reboot
--- prebaseconfig.d/99reboot	21 Dec 2003 16:17:35 -0000	1.8
+++ prebaseconfig.d/99reboot	1 Feb 2004 09:18:32 -0000
@@ -20,9 +20,14 @@ db_capb
 
 # The progress bar is a hack to make sure the previous dialog screen
 # is removed while the system reboots.
-db_progress START 0 1 prebaseconfig/progress/title
+db_progress START 0 2 prebaseconfig/reboot-progress/title
+
+db_progress INFO prebaseconfig/rebot-progress/title
+db_progress STEP 1
 
 /sbin/reboot
 
+db_progress INFO prebaseconfig/rebot-progress/title
 db_progress STEP 1
+
 db_progress STOP

---------------------------------------
Received: (at 230598-close) by bugs.debian.org; 14 Feb 2004 19:04:28 +0000
>From katie@ftp-master.debian.org Sat Feb 14 11:04:28 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1As55Y-00043f-00; Sat, 14 Feb 2004 11:04:28 -0800
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1As53D-0000Zt-00; Sat, 14 Feb 2004 14:02:03 -0500
From: Petter Reinholdtsen <pere@debian.org>
To: 230598-close@bugs.debian.org
X-Katie: $Revision: 1.43 $
Subject: Bug#230598: fixed in prebaseconfig 0.52
Message-Id: <E1As53D-0000Zt-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Sat, 14 Feb 2004 14:02:03 -0500
Delivered-To: 230598-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_02_12 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=no 
	version=2.60-bugs.debian.org_2004_02_12
X-Spam-Level: 

Source: prebaseconfig
Source-Version: 0.52

We believe that the bug you reported is fixed in the latest version of
prebaseconfig, which is due to be installed in the Debian FTP archive:

prebaseconfig_0.52.dsc
  to pool/main/p/prebaseconfig/prebaseconfig_0.52.dsc
prebaseconfig_0.52.tar.gz
  to pool/main/p/prebaseconfig/prebaseconfig_0.52.tar.gz
prebaseconfig_0.52_all.udeb
  to pool/main/p/prebaseconfig/prebaseconfig_0.52_all.udeb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 230598@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Petter Reinholdtsen <pere@debian.org> (supplier of updated prebaseconfig package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat, 14 Feb 2004 19:43:49 +0100
Source: prebaseconfig
Binary: prebaseconfig
Architecture: source all
Version: 0.52
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Petter Reinholdtsen <pere@debian.org>
Description: 
 prebaseconfig - Finish the installation and reboot (udeb)
Closes: 223088 230598
Changes: 
 prebaseconfig (0.52) unstable; urgency=low
 .
   * Updated Translations
     - Bart Cornelis
       - Added corrections send by Bastiaan Eeckhoudt (nl.po)
   * Petter Reinholdtsen
     - Show progress info when executing the prebaseconfig
       parts. (Closes: #230598)
     - Build udeb using the binary-indep, as this package is
       for all archs.  Patch from  Santiago Vila. (Closes: #223088)
Files: 
 29566d031655f02d0a69a88300323b07 707 debian-installer required prebaseconfig_0.52.dsc
 d735c9f2fd6298e49cd7bdb18d4ba68a 27092 debian-installer required prebaseconfig_0.52.tar.gz
 b5d8bfbfb652ab3b9457c5b574b3c254 13104 debian-installer required prebaseconfig_0.52_all.udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFALmzZ20zMSyow1ykRApzDAJ49nGhLx5BB/Yn1IwRKkw7qNmxzzwCgyj+T
P9t9T1K/ARCnwmfn/dyRnGc=
=hLpB
-----END PGP SIGNATURE-----



Reply to: