Bug#219889: marked as done (anna: Poorly handles commas in components descriptions)
Your message dated Sat, 15 Nov 2003 05:17:09 -0500
with message-id <E1AKxUL-0000Ih-00@auric.debian.org>
and subject line Bug#219889: fixed in anna 0.044
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 9 Nov 2003 23:44:06 +0000
>From sprite@sprite.fr.eu.org Sun Nov 09 17:44:04 2003
Return-path: <sprite@sprite.fr.eu.org>
Received: from smtp-100-sunday.nerim.net (kraid.nerim.net) [62.4.16.100]
by master.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1AIzDw-0007BD-00; Sun, 09 Nov 2003 17:44:04 -0600
Received: from sprite.fr.eu.org (sprite.fr.eu.org [213.41.136.74])
by kraid.nerim.net (Postfix) with ESMTP id 12B1F40F2A
for <submit@bugs.debian.org>; Mon, 10 Nov 2003 00:44:02 +0100 (CET)
Received: from spliff.sprite.patnet ([192.168.0.2])
by sprite.fr.eu.org with esmtp (Exim 3.35 #1 (Debian))
id 1AIzDt-0007xO-00; Mon, 10 Nov 2003 00:44:01 +0100
Received: from sprite by spliff.sprite.patnet with local (Exim 4.24)
id 1AIzDu-0003r8-9e; Mon, 10 Nov 2003 00:44:02 +0100
Date: Mon, 10 Nov 2003 00:44:02 +0100
From: Jeremie Koenig <sprite@sprite.fr.eu.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: anna: Poorly handles commas in components descriptions
Message-ID: <[🔎] 20031109234402.GB14756@spliff.sprite.patnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Reportbug-Version: 2.36
User-Agent: Mutt/1.5.4i
Sender: Jeremie Koenig <sprite@spliff.sprite.patnet>
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-7.9 required=4.0
tests=HAS_PACKAGE,PATCH_UNIFIED_DIFF
autolearn=ham version=2.53-bugs.debian.org_2003_11_9
X-Spam-Level:
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_11_9 (1.174.2.15-2003-03-30-exp)
Package: anna
Version: 0.044
Severity: normal
Tags: patch
When selecting which components to load, commas in udeb description
cause debconf to split the list item in two.
I suggest the following fix to be applied (strip out commas in
package_to_choice, in util.c) :
Index: util.c
===================================================================
RCS file: /cvs/debian-boot/debian-installer/anna/util.c,v
retrieving revision 1.26
diff -u -r1.26 util.c
--- util.c 2 Nov 2003 23:07:24 -0000 1.26
+++ util.c 9 Nov 2003 21:34:11 -0000
@@ -141,10 +141,29 @@
return ret;
}
+static size_t
+choice_strcpy(char *dest, char *src, size_t size)
+{
+ size_t n=0;
+
+ while (*src && (n < size-1)) {
+ if (*src != ',')
+ dest[n++] = *src;
+ src++;
+ }
+ dest[n] = '\0';
+
+ return n;
+}
+
size_t
package_to_choice(di_package *package, char *buf, size_t size)
{
- return snprintf(buf, size, "%s: %s", package->package, package->short_description);
+ int n;
+ n = choice_strcpy(buf, package->package, size);
+ n += choice_strcpy(buf+n, ": ", size-n);
+ n += choice_strcpy(buf+n, package->short_description, size-n);
+ return n;
}
char *
--
Jeremie Koenig <sprite@sprite.fr.eu.org>
---------------------------------------
Received: (at 219889-close) by bugs.debian.org; 15 Nov 2003 10:23:25 +0000
>From katie@auric.debian.org Sat Nov 15 04:23:24 2003
Return-path: <katie@auric.debian.org>
Received: from auric.debian.org [206.246.226.45]
by master.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1AKxaO-0000Xl-00; Sat, 15 Nov 2003 04:23:24 -0600
Received: from katie by auric.debian.org with local (Exim 3.35 1 (Debian))
id 1AKxUL-0000Ih-00; Sat, 15 Nov 2003 05:17:09 -0500
From: Petter Reinholdtsen <pere@debian.org>
To: 219889-close@bugs.debian.org
X-Katie: $Revision: 1.43 $
Subject: Bug#219889: fixed in anna 0.044
Message-Id: <E1AKxUL-0000Ih-00@auric.debian.org>
Sender: Archive Administrator <katie@auric.debian.org>
Date: Sat, 15 Nov 2003 05:17:09 -0500
Delivered-To: 219889-close@bugs.debian.org
Source: anna
Source-Version: 0.044
We believe that the bug you reported is fixed in the latest version of
anna, which is due to be installed in the Debian FTP archive:
anna_0.044.dsc
to pool/main/a/anna/anna_0.044.dsc
anna_0.044.tar.gz
to pool/main/a/anna/anna_0.044.tar.gz
anna_0.044_i386.udeb
to pool/main/a/anna/anna_0.044_i386.udeb
load-installer_0.044_all.udeb
to pool/main/a/anna/load-installer_0.044_all.udeb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 219889@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Petter Reinholdtsen <pere@debian.org> (supplier of updated anna package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sat, 15 Nov 2003 11:13:37 +0100
Source: anna
Binary: anna load-installer
Architecture: source i386 all
Version: 0.044
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Petter Reinholdtsen <pere@debian.org>
Description:
anna - anna's not nearly apt, but for the Debian installer, it will do (udeb)
load-installer - Load installer components (udeb)
Closes: 219889
Changes:
anna (0.044) unstable; urgency=low
.
* Peter Mann
- Initial Slovak translation (sk.po).
* KÄ?stutis BiliÅ«nas
- Updated Lithuanian translation.
* Matt Kraai
- Make the menu entry for load-installer translatable.
* André LuÃs Lopes
- Run debconf-updatepo to feed one additionnal template to translators.
- Updatept_BR (Brazilian Portuguese) translation.
* Jeremie Koenig
- Escape commas in package descriptions. (Closes: #219889)
* Miroslav Kure
- Update Czech translation.
* Petter Reinholdtsen
- Update nb.po.
* Christian Perrier
- Update French translation.
* Tommi Vainikainen
- Update Finnish translation.
* Kenshi Muto
- Update Japanese translation (ja.po)
* Bart Cornelis
- Updat Dutch translation (nl.po)
* Claus Hindsgaul
- Update da (Danish) translation.
Files:
e63a76270c41dd42b99f11a510b5f2eb 673 debian-installer standard anna_0.044.dsc
a37f3b8639fd871772e3eba3b096bc57 78237 debian-installer standard anna_0.044.tar.gz
fe0bcfad4347fc7286eca2d8b7475e07 968 debian-installer extra load-installer_0.044_all.udeb
ef313ec881e15ccc02175720760168c9 12332 debian-installer standard anna_0.044_i386.udeb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
iD8DBQE/tfx220zMSyow1ykRAlxmAJwP5mMNcwPMjeUJas3e/Bjmot3NeQCeKwkX
g6PLd//aeaVZ/+PbII7tulA=
=gKOG
-----END PGP SIGNATURE-----
Reply to: