[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [d-i] Yet Another bug with pre-sprintf malloc:ing



ons 2002-08-28 klockan 09.51 skrev Martin Sjögren:
> ons 2002-08-28 klockan 09.34 skrev Colin Walters:
> > On Mon, 2002-08-26 at 06:51, Martin Sjögren wrote:
> > > I found Yet Another bug with "pre-sprintf" malloc:ing in anna (in
> > > retriever.c, get_packages), a patch is attached.
> > 
> > This kind of thing is exactly why GNU came up with the "asprintf"
> > extension.  Since we're using glibc and gcc, I suggest we have a policy
> > of allowing GNU extensions, such as glibc library functions, and GNU C.
> 
> That's what I realized too while blubbering about with glib's
> g_strdup_printf. I don't see how it would harm to use GNU extensions.

I mucked about a bit. Turns out that anna, main-menu, choose-mirror and
wget-retriever are already compiled with -D_GNU_SOURCE. udpkg, however,
is not. I don't really see much of a reason for anyone to use udpkg
without "the rest" of d-i, which already use GNU extensions. I don't
think this is my call though. :)


Regards,
Martin

Attachment: signature.asc
Description: Detta =?ISO-8859-1?Q?=E4r?= en digitalt signerad meddelandedel


Reply to: