Re: supernovas v1.2.0 ready to upload.

[Ole Streicher <olebole@debian.org>]

Hi Attila,

sorry for not acting earlier; however I now reviewed your new package.

Attila Kovacs <attipaci@gmail.com> writes:
> I've updated the supernovas package to the upstream v1.2.0 release. It
> has a clean build on salsa. I have also tweaked the watch file so that
> release candidates are properly uversionmangle'd for the tracker.

I have a one major comments here:

Please include the changes on the Debian package in debian/changelog.
Just a generic "Update to upstream SuperNOVAS v1.2.0" is sufficient only
if the only change is merging the new upstream sources. But aside from
that, you changed quite a few other things, like the removal of a patch,
fixes to debian/rules, adjustment of d/watch, and even a new binary
library package. All these changes should be documented in d/changelog.

If you would have committed the changes separately to Git (which would
be greatly appreciated) then you could generate the entry in
debian/changelog with a simple "gbp dch -R --commit"; I'd recommend to
try this out when you create the next revision. For this one, I would
ask you to update the changelog manually to include the different
changes you made on the Debian package. Then I would upload.

As there is a new binary package, this needs to go through NEW, so it
needs manual approval by the ftp-masters.

Best

Ole