Hi Attila, On Sun, Jun 02, 2024 at 06:36:18PM +0200, Attila Kovacs wrote: > Thanks Nilesh for cleaning things up nicely, and for offering to sponsor it. > I'll gladly accept your offer! > > > I'm generally OK with the renaming to follow the library style guide. I do > find it a little particular (and awkward) though for two reasons: > > 1. the libsolsys1-1, and libsossys2-1 are somewhat awkward although if that > is the standard for naming packaghed libs that have a number as part of > their name, then it is what it is. In general packages should match the name of the so that they provide unless you have a very good reason not to. The .so in them are libsolsys1.so.1 and libsolsys2.so.1 and hence the names. Maybe it'd make sense to rename .so files to something else as upstream? Not sure, but it does not look like a big concern. > 2. For libsolsys1-1 and libsolsys2-1, the package names hide that these > belong to the supernovas package (that they are optional packages thereof). > I guess that's OK, since the dependencies are there. Perhaps you could add a > 'Suggests' to libsupernovas1, so they are more easily discoverable by users > who might be wondering what packages might provide the legacy > functionalities... Fine, can do. > I'm curious, how did you manage to import the upstream with the same version > '1.0.1-2'? I have utterly failed doing that even though I wasted a full day > trying as I might. :-) I was pretty easy after fixing d/watch and removing the annoying uupdate. $ uscan -dd --verbose --download-version 1.0.1-2 worked. > Finally, I noticed you removed the version dependence on doxygen. Maybe > that's OK, but the fact is that older versions of doxygen will caugh up an > error with the Doxyfile configuration, as it contains settings that are not > supported in earlier releases of doxygen. (If you do change your mind on > specifying a minimum version, you probably want it to be the current one, > which is 1.10, I think). It was some automated tooling (cme) that did so. The uploads to packages go through unstable and are built with packages in unstable. Sometimes you want to backport things to stable, and very rarely to old-stable. Debian versions before that are mostly unsupported. The version of doxygen in even old stable is 1.9.1 so the version dep is not needed as such. Keeping it does not hurt, sure but there's no utility per se. There's some confusion going on on whether to use !cross profile or not and I'm talking to people in #debian-bootstrap. Once that's closed, I'll make the change for cross builds, add a suggests on libsupernovas1 for libsolsys* and upload to the NEW queue. It will then be reviewed by the FTP masters before accepting it into the archive. Best, Nilesh
Attachment:
signature.asc
Description: PGP signature